test: cover brief agent-mode output - #212
Merged
Rome-1 merged 1 commit intoJul 29, 2026
Merged
Conversation
Co-Authored-By: OpenAI Codex <codex@openai.com>
Collaborator
|
Thanks — this is a clean, well-scoped addition. Checked it against the tree: the Appreciate scoping it to the agent-mode slice and leaving the internal-helper parity as a follow-up on #28. Merging — thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds matching regression tests for
rafter --agent brief scanningin Node and Python. The Node test usesspawnSyncto capture both output streams, while the Python test invokes the root Typer app withcolor=True. Both cases require a successful exit and real Rafter content, then reject escape characters and emoji so agent mode stays plain.Why
Issue #28 originally listed broader
briefcoverage, but most of that coverage landed before this change. In the issue discussion, the maintainer identified agent-mode output as the highest-priority remaining gap. Both CLIs already produce plain output; this PR adds mirrored regression coverage so a later formatting change cannot silently break that contract.Related issue
Addresses the agent-mode portion of #28. The Node internal-helper parity work remains a separate follow-up.
Test plan
pnpm run buildpnpm exec vitest run tests/brief.test.ts(29 passed).\.venv\Scripts\pytest.exe tests\test_brief.py -v(36 passed)pnpm test(1,986 passed, 53 skipped)python -m pytest tests/ -v(1,540 passed, 9 skipped)git diff --check upstream/main...HEADnode .\node\dist\index.js secrets . --diff upstream/main --engine patterns --no-auto-update --format json(zero findings)rafter run --mode fast(scan77e6f82e-ebd7-422a-bc14-1f54ab73e68d): no findings in either changed test file. Those files remained byte-identical after the conflict-free rebase. The repository-wide scan also reported 20 errors, 32 warnings, and 54 notes in unmodified files.Spec update
None. This is a test-only change and does not alter CLI behavior.
Checklist
pnpm test+pytest)node/package.jsonandpython/pyproject.tomlshared-docs/CLI_SPEC.mdupdated (not required because CLI behavior did not change)Prepared with OpenAI Codex. The commit includes a
Co-Authored-Bytrailer.