Skip to content

unity-cli@v1.1.0#15

Merged
StephenHodgson merged 33 commits intomainfrom
dev
Oct 5, 2025
Merged

unity-cli@v1.1.0#15
StephenHodgson merged 33 commits intomainfrom
dev

Conversation

@StephenHodgson
Copy link
Copy Markdown
Member

@StephenHodgson StephenHodgson commented Oct 4, 2025

  • Process cleanup
    • Replaced TryKillProcess with async KillProcess that escalates to SIGKILL / taskkill after a timeout.
    • KillChildProcesses now collects and awaits child-kill promises instead of fire-and-forget.
    • Call sites updated to use/await the new APIs where applicable.
  • Log/tailing & stdout handling
    • Added TailLogFile to tail Unity log files robustly (periodic reads + final flush + EPIPE handling).
    • Exec and spawn wrappers now buffer incomplete lines, flush on close, and write whole lines to stdout.
    • Helpers added to wait for files to be created/readable and to wait for file unlocks.
  • Unity Editor & Hub lifecycle
    • UnityEditor.Run: ensures -automated/-batchmode/-logFile args, waits for log file, tails logs while process runs.
    • Cancellation triggers KillProcess + KillChildProcesses to ensure cleanup.
    • UnityHub now parses streamed output more safely, triggers KillProcess on completion messages.
  • CLI & GitHub Actions integration
    • CLI commands call Logger.instance.setEnvironmentVariable to persist UNITY_* values for subsequent workflow steps.
    • Logger writes to GITHUB_ENV / GITHUB_OUTPUT when available.
  • CI/workflow
    • Workflow split into setup unity-cli and setup unity steps, added env verification steps.
  • Misc
    • Version bump to 1.0.14 and multiple lockfile/devDependency updates.
    • Added small utilities: PromptForSecretInput, Delay, TestFileAccess.
    • Several listener cleanup and robustness fixes (removeListener guards, safer regex parsing).

- refactor process kill logic
Copilot AI review requested due to automatic review settings October 4, 2025 14:51

This comment was marked as outdated.

@StephenHodgson StephenHodgson requested a review from Copilot October 4, 2025 15:46

This comment was marked as outdated.

@StephenHodgson StephenHodgson requested a review from Copilot October 4, 2025 16:41

This comment was marked as outdated.

@StephenHodgson StephenHodgson requested a review from Copilot October 5, 2025 04:59
Comment thread src/utilities.ts Fixed

This comment was marked as outdated.

@StephenHodgson StephenHodgson requested a review from Copilot October 5, 2025 14:19
Comment thread src/utilities.ts Dismissed
Comment thread src/utilities.ts Dismissed

This comment was marked as outdated.

@StephenHodgson StephenHodgson requested a review from Copilot October 5, 2025 14:50
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/utilities.ts
@StephenHodgson StephenHodgson changed the title unity-cli@v1.0.14 unity-cli@v1.1.0 Oct 5, 2025
@StephenHodgson StephenHodgson merged commit 9a8a6ac into main Oct 5, 2025
4 of 7 checks passed
@StephenHodgson StephenHodgson deleted the dev branch October 5, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants