Merged
Conversation
- refactor process kill logic
Commented out some lines
add ability to write to github env and output temp files
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TryKillProcesswith asyncKillProcessthat escalates to SIGKILL /taskkillafter a timeout.KillChildProcessesnow collects and awaits child-kill promises instead of fire-and-forget.TailLogFileto tail Unity log files robustly (periodic reads + final flush + EPIPE handling).Execand spawn wrappers now buffer incomplete lines, flush on close, and write whole lines to stdout.UnityEditor.Run: ensures-automated/-batchmode/-logFileargs, waits for log file, tails logs while process runs.KillProcess+KillChildProcessesto ensure cleanup.UnityHubnow parses streamed output more safely, triggersKillProcesson completion messages.Logger.instance.setEnvironmentVariableto persistUNITY_*values for subsequent workflow steps.Loggerwrites toGITHUB_ENV/GITHUB_OUTPUTwhen available.setup unity-cliandsetup unitysteps, added env verification steps.1.0.14and multiple lockfile/devDependency updates.PromptForSecretInput,Delay,TestFileAccess.