Add isAdministratorRoute flag to admin reporting routes + regenerate OpenAPI - #117
Merged
Conversation
Co-authored-by: owens1127 <98496129+owens1127@users.noreply.github.com>
…API docs Co-authored-by: owens1127 <98496129+owens1127@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add API to retrieve player standing information
Add isAdministratorRoute flag to admin reporting routes + regenerate OpenAPI
Feb 22, 2026
owens1127
marked this pull request as ready for review
February 22, 2026 03:30
Barecheck - Code coverage reportTotal: 92.87%Your code coverage diff: 0.01% ▴ Uncovered files and lines
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a missing configuration flag on four admin reporting routes that caused the OpenAPI specification to be incomplete. The routes were missing isAdministratorRoute: true, which resulted in the generated OpenAPI spec omitting 403 Forbidden responses and Administrator Token security schemes.
Changes:
- Added
isAdministratorRoute: trueflag to four admin reporting route constructors - Fixed stale copy-pasted description in instance-standing route to accurately describe its purpose
- Regenerated OpenAPI specification to include proper 403 responses and security schemes for all four routes
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/routes/admin/reporting/player.ts | Added isAdministratorRoute: true to patchPlayer route |
| src/routes/admin/reporting/player-standing.ts | Added isAdministratorRoute: true to getPlayerStanding route; cleaned up import formatting |
| src/routes/admin/reporting/instance-standing.ts | Added isAdministratorRoute: true and fixed stale description to accurately describe the instance standing endpoint |
| src/routes/admin/reporting/blacklist.ts | Added isAdministratorRoute: true to blacklistInstanceRoute |
| open-api/openapi.json | Regenerated OpenAPI spec with 403 Forbidden responses and Administrator Token security schemes for all four reporting routes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All four admin reporting routes were missing
isAdministratorRoute: true, so the generated OpenAPI spec omitted 403 responses and "Administrator Token" security schemes for those routes. This caused theverify-open-api-docCI check to fail (committed spec ≠ freshly generated spec).Changes
player-standing.ts,instance-standing.ts,blacklist.ts,player.ts— addedisAdministratorRoute: trueto eachRaidHubRouteconstructorinstance-standing.ts— replaced stale copy-pasted description with an accurate oneopen-api/openapi.json— regenerated; all four reporting routes now carry 403 +Administrator Tokensecurityexport const getPlayerStanding = new RaidHubRoute({ + isAdministratorRoute: true, method: "get", ... })Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.