Add structured audit logging for admin mutation routes - #143
Merged
Conversation
Emit ADMIN_ACTION logs with actor, request, and outcome so manual blacklist and other privileged API changes are traceable in production logs. Co-authored-by: Cursor <cursoragent@cursor.com>
Barecheck - Code coverage reportTotal: 91.4%Your code coverage diff: 0.48% ▴ |
Co-authored-by: Cursor <cursoragent@cursor.com>
Cover writeAuditLog, sanitizeForAudit edge cases, middleware failure paths, and RaidHubRoute audit wiring. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writeAuditLog,auditRoute,sanitizeForAudit) that emits structuredADMIN_ACTIONlogs via theAUDITloggerauditconfig toRaidHubRouteso important routes opt in without handler changesEach log includes actor Bungie membership ID, route, outcome, sanitized request params/body, and selected response fields — so manual UI blacklists (e.g. from PGCR menu) are traceable in Loki/Grafana even though Postgres only stores the blacklist row itself.
Test plan
bun test src/middleware/audit-log.test.tsbun typecheck,bun lint,bun format --checklocallyMade with Cursor