Fix community race leaderboard showing DNF players

[owens1127]

Summary

• Filter the pantheon community race team leaderboard player query to completed instance_player rows only, matching contest/first team leaderboards
• No player ordering (same as other team leaderboards)

Companion PR: Raid-Hub/Services#60 (materialized view + post-merge SQL)

Test plan

• Open /leaderboard/team/custom/pantheon-community-race and confirm cleared runs no longer show DNF players

Deploy notes

Deploying this API change fixes the displayed player list immediately. Run the post-merge SQL from the Services PR to keep search (membership_ids) in sync.

[sentry]

Bug: The JSONB_AGG for players can return NULL if all players in an entry are filtered out, but the Zod schema expects an array, causing a validation error.
_{Severity: HIGH}

Suggested Fix

Wrap the JSONB_AGG(...) call in the SQL query with COALESCE(JSONB_AGG(...), '[]'::jsonb). This ensures that if no players match the filter, an empty array [] is returned instead of NULL, satisfying the Zod schema and preventing validation errors.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: src/services/leaderboard/team/custom.ts#L42

Potential issue: The SQL query filters players using `AND instance_player.completed`. If
a leaderboard entry contains only players who did not complete the activity, the
`JSONB_AGG` function will operate on an empty set and return `NULL`. However, the Zod
schema `zTeamLeaderboardEntry` defines the `players` field as a non-nullable array. When
the query result with a `NULL` `players` field is parsed, it will fail Zod validation,
resulting in an API error for requests involving such leaderboard entries. This is
likely for custom race leaderboards which may contain teams composed entirely of DNF
players.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

[barecheck]

Barecheck - Code coverage report

Total: 91.42%

Your code coverage diff: 0.00% ▴

Uncovered files and lines

File	Lines
src/services/leaderboard/team/custom.ts	74-80

[sentry]

Bug: A temporal inconsistency between deployment and a SQL migration causes searches for DNF players to return their team but omit them from the player list, breaking tests.
_{Severity: MEDIUM}

Suggested Fix

The issue is caused by a temporary desynchronization between the search index and the query filter. The documented solution is to run the companion SQL migration immediately after API deployment to update the membership_ids column and remove DNF players, ensuring data consistency. Alternatively, modify the deployment process to prevent the API from being live until the migration is complete.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: src/services/leaderboard/team/custom.ts#L44

Potential issue: A temporal data inconsistency occurs between the API deployment and a
companion SQL migration. The `searchPantheonCustomRaceTeamLeaderboard` function can find
a team using a DNF player's ID from the `membership_ids` column, which is not yet
updated. However, the `getPantheonCustomRaceTeamLeaderboard` function then filters out
this player using the new `AND instance_player.completed` clause. This results in an API
response where a team is found for a player, but that player is missing from the
returned `players` array, causing the `assertTeamSearchIncludesMembership` test to fail.