Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic for determining whether an activity instance qualifies as "Day One" or "Contest" eligible. The main change is to use the
is_contest_eligibleflag instead ofis_world_firstfor these determinations, ensuring more accurate classification of activity instances. Additionally, new tests have been added to verify the updated contest eligibility logic.Contest and Day One eligibility logic update:
getInstance,getInstances,getActivities, andgetPlayerActivityStatsto useav.is_contest_eligibleinstead ofav.is_world_firstfor calculatingisDayOneandisContestflags. This ensures that these flags correctly reflect contest eligibility rather than world first status. [1] [2] [3] [4]Testing improvements:
instance.test.tsto verify contest and day one status for specific activities, including day one King's Fall and Leviathan instances.