Skip to content

Fix reprised raid, non-challenge not getting contest - #96

Merged
owens1127 merged 1 commit into
mainfrom
fix-bug
Aug 9, 2025
Merged

Fix reprised raid, non-challenge not getting contest#96
owens1127 merged 1 commit into
mainfrom
fix-bug

Conversation

@owens1127

@owens1127 owens1127 commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

This pull request updates the logic for determining whether an activity instance qualifies as "Day One" or "Contest" eligible. The main change is to use the is_contest_eligible flag instead of is_world_first for these determinations, ensuring more accurate classification of activity instances. Additionally, new tests have been added to verify the updated contest eligibility logic.

Contest and Day One eligibility logic update:

  • Updated SQL queries in getInstance, getInstances, getActivities, and getPlayerActivityStats to use av.is_contest_eligible instead of av.is_world_first for calculating isDayOne and isContest flags. This ensures that these flags correctly reflect contest eligibility rather than world first status. [1] [2] [3] [4]

Testing improvements:

  • Added new tests in instance.test.ts to verify contest and day one status for specific activities, including day one King's Fall and Leviathan instances.

@owens1127
owens1127 marked this pull request as ready for review August 8, 2025 23:52
@owens1127
owens1127 merged commit a9f64dc into main Aug 9, 2025
4 of 5 checks passed
@owens1127
owens1127 deleted the fix-bug branch August 9, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant