Skip lowman checks during known strat windows (beta-2.2.4) - #64
Merged
Conversation
Per-player-count lowman entries with CheatedChance above threshold still flagged and blacklisted legit clears after the Koregos glitch and Pantheon boss-push strats. Centralize skips in skipLowmanForKnownStrat instead. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
Prod bitmap verification (pre-merge)Queried Key corrections from draft backfill:
Dry-run each |
Co-authored-by: Cursor <cursoragent@cursor.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheatedChancevalues above the0.05flag threshold, and/or only covered solo while duo/trio still hitTooFewPlayersat0.995→ cronBlacklistFlaggedInstances(>= 0.95) blacklisted thousands of legit clears.skipLowmanForKnownStratinmethods.goskips lowman heuristics entirely during the bubble push-off glitch window (kill/time checks still run). Removed per-player-count pantheon boss-push lowman hacks fromheuristics.go.bubblePushOffGlitchStart=2026-06-14— Desert Perpetual (activity 15, fresh + checkpoint); Garden / VoG / Vow / RoN final-boss checkpoint only (activities 7, 9, 10, 12); Pantheon 2 Morgeth + Insurrection Prime Rev (activity 102, versions 133/134).Deploy
Post-merge backfill (
clear-flags)Use
tools/clear-flags. It clears matchingflag_instance/flag_instance_playerrows (versions ≠ currentCheatCheckVersion), removes blacklists for those instances, and resetscheat_levelfor affected players.clear-flagsmatches(cheat_check_bitmask & bitmap) = bitmap— all bits in the filter must be present. Extra bits (e.g.Solo) on the row are fine.Note:
clear-flagsfilterscheat_check_version != current(notIN ('beta-2.2.2','beta-2.2.3')), so dry-run counts for Garden/VoG can include older-version lowmans. Prefer verifyingbeta-2.2.2/beta-2.2.3counts via admin SQL before apply.Prod-verified bitmaps (2026-06-18,
beta-2.2.2/beta-2.2.3,flag_instance)-bitmapvalueTooFewPlayersFresh4611686018427420672UnlikelyLowman562949953454080UnlikelyLowman562967133290496TooFewPlayersCheckpoint2305843026393563136TooFewPlayersFresh4611686035607257088UnlikelyLowman562949953421440UnlikelyLowman562949953421824Do not clear:
RaidBit | TotalInstanceKills(e.g. VoG18014398509482496, n=643) — kill heuristic still active.On prod (after Hermes is on
beta-2.2.4):Re-enqueue rechecks after clearing so instances get a clean
beta-2.2.4pass.Test plan
go build ./lib/services/cheat_detection/...strings bin/hermes | grep beta-2.2.4clear-flags -dry-runeach row; counts should match ~prod table aboveclear-flags+ enqueue rechecks