Skip to content

E2E tests removed from push to main#751

Merged
Amir-R25 merged 1 commit into
mainfrom
push_to_main
Oct 3, 2025
Merged

E2E tests removed from push to main#751
Amir-R25 merged 1 commit into
mainfrom
push_to_main

Conversation

@Amir-R25

@Amir-R25 Amir-R25 commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

What does this add?

It was discovered that upon forking the repo, tests would fail on syncing the fork due to not having the relevant api keys in the fork repo. We have decided to remove the E2E testing on pushing to main since they will already be tested before pr approval by maintainers running the workflow manually.

Type of changes

Please check the type of change your PR introduces:

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update (improvements or corrections to documentation)
  • 🎨 Code style/formatting (changes that do not affect the meaning of the code)
  • ♻️ Refactoring (code change that neither fixes a bug nor adds a feature)
  • ⚡ Performance improvement (code change that improves performance)
  • ✅ Test update (adding missing tests or correcting existing tests)
  • 🔧 Build/CI changes (changes to build process or continuous integration)
  • 🗑️ Chore (other changes that don't modify src or test files)

Additional Notes

cc: @jbueza

@Amir-R25
Amir-R25 requested a review from soulFood5632 as a code owner October 3, 2025 16:45

@soulFood5632 soulFood5632 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amir-R25
Amir-R25 merged commit 8997780 into main Oct 3, 2025
6 checks passed
@Amir-R25
Amir-R25 deleted the push_to_main branch October 3, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants