Stop hardcoding the SETTING::OUTER depth in SETTING-6e.t#887
Merged
Conversation
The original test baked in SETTING::OUTER::OUTER::OUTER::OUTER, which broke once the 6.e PseudoStash adjusted how far past the unit marker SETTING:: lands. Discover the depth at runtime and assert the lookup forms (top-level indirect, indirect inside EVAL, CALLER indirect) rather than a specific OUTER count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original test baked in SETTING::OUTER::OUTER::OUTER::OUTER, which broke once the 6.e PseudoStash adjusted how far past the unit marker SETTING:: lands. Discover the depth at runtime and assert the lookup forms (top-level indirect, indirect inside EVAL, CALLER indirect) rather than a specific OUTER count.
Allows this test to pass against a
RAKUDO_RAKUAST=1-built rakudo