connect grandpa rpc - #302
Merged
Merged
Conversation
Contributor
Author
|
The PR looks good to me, the grandpa rpc is supported. |
sam0x17
approved these changes
Apr 9, 2024
Comment on lines
+245
to
+262
| Box::new(move |deny_unsafe, subscription_executor: sc_rpc::SubscriptionTaskExecutor| { | ||
| let deps = | ||
| crate::rpc::FullDeps { | ||
| client: client.clone(), | ||
| pool: pool.clone(), | ||
| deny_unsafe, | ||
| grandpa: crate::rpc::GrandpaDeps { | ||
| shared_voter_state: shared_voter_state.clone(), | ||
| shared_authority_set: shared_authority_set.clone(), | ||
| justification_stream: justification_stream.clone(), | ||
| subscription_executor: subscription_executor.clone(), | ||
| finality_provider: finality_proof_provider.clone(), | ||
| }, | ||
| backend: rpc_backend.clone(), | ||
| }; | ||
| crate::rpc::create_full(deps).map_err(Into::into) | ||
| }) | ||
| }; |
Contributor
There was a problem hiding this comment.
lot of boxing and cloning here, I wonder if it is actually all necessary?
Contributor
Author
There was a problem hiding this comment.
I just checked, all clones are needed. can't fully understand the grammar yet, like need a new variable then box can pin them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pr is from MacieRaj, rebased with development branch.