Skip to content

Seaborn+Matplotlib incompability#78

Merged
enryH merged 19 commits intomainfrom
fix_colormap_error
Aug 21, 2024
Merged

Seaborn+Matplotlib incompability#78
enryH merged 19 commits intomainfrom
fix_colormap_error

Conversation

@enryH
Copy link
Copy Markdown
Member

@enryH enryH commented Aug 20, 2024

  • incompability of seaborn 0.12 with matplotlib 3.9 (some internal seaborn relies on were changed)
    New PR will need to do seaborn update:

    • need to update to seaborn 0.13 (_BarPlotter was removed)
    • added some test for errors function which failed, to prepare refactoring
  • art: cleaned up some test and formatted package a bit

enryH and others added 19 commits August 2, 2024 15:37
- move tests around a bit
- comparions needs it's own environment (ToDo)

! still needs to be documented if this works
- run does not allow conda env to be specified
- looks matplotlib change their API in 3.9
- out-of-memory in GitHub runner
- disk space wasn't freed otherwise
- one global pimms environment next to a R environment might be the better solution.
- list files in project folder (to check if .snakemake is deleted)
- seaborn lock needs to be removed to fix that.
Some state fails (both test work individually with the fixtures, but not if the other is run first - the second one fails)
Can be both orders...

fix: reload the data explicitly, no caching
- running order matters...
  - `test_errors.py` fails if `test_models.py`
     is run before. I don't know fastai or other might change in the state.
  - running only `test_errors.py` works fine, running it before as well.

- made some adoptions to other tests which clutter the commit a bit.
- int32 vs int64 defaults on different OS?
- change folder to None and pass explicitly
@enryH enryH merged commit c40bcbb into main Aug 21, 2024
@enryH enryH deleted the fix_colormap_error branch August 21, 2024 08:17
@jlthepi jlthepi mentioned this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant