chore: move formatting to root level#10128
Merged
Merged
Conversation
gonfunko
approved these changes
Jul 10, 2026
Comment on lines
+8
to
+33
| packages/blockly/msg/* | ||
| packages/blockly/build/* | ||
| packages/blockly/dist/* | ||
| packages/blockly/typings/* | ||
| packages/blockly/docs/* | ||
|
|
||
| # Core: Tests other than mocha unit tests | ||
| packages/blockly/tests/blocks/* | ||
| packages/blockly/tests/themes/* | ||
| packages/blockly/tests/compile/* | ||
| packages/blockly/tests/jsunit/* | ||
| packages/blockly/tests/generators/* | ||
| packages/blockly/tests/mocha/webdriver.js | ||
| packages/blockly/tests/screenshot/* | ||
| packages/blockly/tests/test_runner.js | ||
| packages/blockly/tests/workspace_svg/* | ||
|
|
||
| # Core: Demos, scripts, misc | ||
| packages/blockly/node_modules/* | ||
| packages/blockly/demos/* | ||
| packages/blockly/appengine/* | ||
| packages/blockly/externs/* | ||
| packages/blockly/closure/* | ||
| packages/blockly/scripts/gulpfiles/* | ||
| packages/blockly/CHANGELOG.md | ||
| packages/blockly/PULL_REQUEST_TEMPLATE.md |
Contributor
There was a problem hiding this comment.
I realize these were copied from the old config file, but a variety of these no longer exist (in particular closure, externs, tests/blocks, tests/jsunit, tests/screenshot, tests/workspace_svg, and possibly others?) Optional, but would be nice to clean this up and remove them (and anything else obsolete in other config files)
Contributor
Author
There was a problem hiding this comment.
I always like an opportunity to remove cruft! I'll compare these to the directories and remove anything that's no longer present.
| packages/blockly/PULL_REQUEST_TEMPLATE.md | ||
|
|
||
| # Core: Don't bother formatting JavaScript files we're about to migrate: | ||
| packages/blockly/generators/**/*.js |
Contributor
There was a problem hiding this comment.
This migration is done, and this rule can also be removed.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7761
Proposed Changes
This change moves the following to the root level:
Reason for Changes
This change helps to get the workspace ready for moving the plugins over to the monorepo.
Test Coverage
No test coverage. I validated my changes by inserting formatting errors in the core and docs workspaces and ensuring prettier still catches them and doesn't catch anything it shouldn't.
Before my changes:
After my changes:
