fix: add comma to block labels except on Apple devices - #10279
Open
mikeharv wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10185
Proposed Changes
Conditionally adds a comma to the end of valid block ARIA labels except on Apple devices.
Reason for Changes
It is not possible to detect what screen reader is in use, if any. This uses OS as a proxy so that the users with the most common screen reader readers will get the optimal output.
Test Coverage
3 tests needed to be relaxed as the expected strings did not each include an ending comma.
I tested for regressions on my Mac and found none. I was not able to manually test on Windows, but I believe the fix is straight-forward enough.