revert: "refactor: Remove block and workspace drag surfaces (#6758)"#6888
Merged
Merged
Conversation
…yPiFoundation#6758)" This reverts commit 332c0fd.
BeksOmega
approved these changes
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 332c0fd.
The basics
npm run formatandnpm run lintThe details
Resolves
Reverts #6758
Proposed Changes
While we do plan to remove the block drag surface, doing so is a breaking change. We don't plan on doing a major release for the upcoming release, therefore I'm reverting that change, and we can re-implement this in the future.
Note this did not revert cleanly due to subsequent changes to remove
AnyDuringMigrations. I believe I've applied those changes correctly here.Behavior Before Change
Behavior After Change
Reason for Changes
Test Coverage
Manual testing in playground.
Documentation
We could call out in the release notes (or separate news announcement) that we plan to remove drag surfaces soon so that developers can prepare.
Additional Information
Not sure how this impacts #6874 because I haven't read that PR yet.