fix!: re-remove block and workspace drag surfaces#7070
Merged
BeksOmega merged 8 commits intoMay 11, 2023
Conversation
79138c0 to
b497dd8
Compare
rachel-fenichel
approved these changes
May 11, 2023
This was referenced Jul 27, 2023
|
Dragging a blocklyDraggable element onto a blocklyToolboxDiv element will be obstructed by blocklyToolboxDiv, making it impossible to elevate the blocklyDraggable element level. Originally, raising the blocklyBlockDragSurface element level was sufficient. How can we solve this problem? blocklyDraggable元素拖拽到blocklyToolboxDiv元素会被blocklyToolboxDiv遮挡,无法提升blocklyDraggable元素层级,原来通过提升blocklyBlockDragSurface元素层级即可,如何解决这个问题? |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reversion of reversion #6888
Reapplication of #6758
(Re) Fixes #6160
The details
Proposed changes
Removes the block drag surface and the workspace drag surface from Blockly.
Reason for changes
Both of these were implemented as a performance optimization, but have since become a performance sink. Removing these gives us a significant boost in FPS.
Breaking changes / updating / upgrading
Unless you were accessing the drag surface directly, this change should not affect you.
If you were accessing the drag surface directly, you should now access either the workspace
svgGroup_or thesvgBlockCanvas_. Here is an example PR that updates the scroll-options plugin: https://github.com/google/blockly-samples/pull/1666/filesNote that we are planning to create more formal get methods to replace these properties in the future (see #7157). If you have opinions about this please feel welcome to leave comments there!