fix: Restore HSV_SATURATION and HSV_VALUE accessors and deprecate#7249
Merged
cpcallen merged 2 commits intoRaspberryPiFoundation:developfrom Jul 5, 2023
Merged
fix: Restore HSV_SATURATION and HSV_VALUE accessors and deprecate#7249cpcallen merged 2 commits intoRaspberryPiFoundation:developfrom
HSV_SATURATION and HSV_VALUE accessors and deprecate#7249cpcallen merged 2 commits intoRaspberryPiFoundation:developfrom
Conversation
Contrary to the notice at the top of the `Object.defineProperties` call, these were not actually marked as deprecated, and their removal in Blockly 10.0.0 constituted an avoidable zero-notice breaking change.
DEPRECATION: Blockly.HSV_SATURATION and Blockly.HSV_VALUE are deprecated and will be removed in a future version of Blockly. Use Blockly.colour.getHsvSaturation / Blockly.colour.setHsvSaturation and Blockly.colour.getHsvValue / Blockly.colour.setHsvValue instead.
cpcallen
force-pushed
the
fix/hsv-accessors
branch
from
7818508 to
65c6291
Compare
cpcallen
changed the title
HSV_SATURATION and HSV_VALUE accessors and deprecate
github-actions
Bot
added
PR: fix
rachel-fenichel
approved these changes
Jul 5, 2023
ericblackmonGoogle
pushed a commit
that referenced
this pull request
Jul 10, 2023
…#7249) * fix: Restore HSV_SATURATION and HSV_VALUE accessors Contrary to the notice at the top of the `Object.defineProperties` call, these were not actually marked as deprecated, and their removal in Blockly 10.0.0 constituted an avoidable zero-notice breaking change. * deprecate: Add deprecation notices for HSV_SATURATION and HSV_VALUE DEPRECATION: Blockly.HSV_SATURATION and Blockly.HSV_VALUE are deprecated and will be removed in a future version of Blockly. Use Blockly.colour.getHsvSaturation / Blockly.colour.setHsvSaturation and Blockly.colour.getHsvValue / Blockly.colour.setHsvValue instead. (cherry picked from commit a677355)
|
Hello, the depecration message should include "utils" in the namespace. Thus it should be: |
github-actions
Bot
added
PR: fix
Contributor
|
Fixed! Thanks @chrisbansart =) |
Collaborator
Author
|
@BeksOmega: I do not see any for the problem @chrisbansart mentions in either |
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Jul 17, 2023
Fix the comment / message errors noted in RaspberryPiFoundation#7249 (comment)
4 tasks
cpcallen
added a commit
that referenced
this pull request
Jul 17, 2023
* fix: Correct errors in HSV_SATURATION, HSV_VALUE accessors Fix the comment / message errors noted in #7249 (comment) * chore: Add renamings for HSV_SATURATION, HSV_VALUE
ericblackmonGoogle
pushed a commit
that referenced
this pull request
Jul 17, 2023
* fix: Correct errors in HSV_SATURATION, HSV_VALUE accessors Fix the comment / message errors noted in #7249 (comment) * chore: Add renamings for HSV_SATURATION, HSV_VALUE (cherry picked from commit 1bc4f67)
ericblackmonGoogle
added a commit
that referenced
this pull request
Jul 17, 2023
* fix(generators): Changes to exports and access controls for TypeScript compatibility (#7295) * fix(generators): Add missing declarations for Order enums * chore(generators): Remove spurious whitespace * fix(generators): Make provideFunction_ etc. public Remove the protected declaration on provideFunction_ and FUNCTION_NAME_PLACEHOLDER_ so they can be used from generator functions written in TypeScript. Not strictly part of #7283, but closely related and required to fixing the related issue RaspberryPiFoundation/blockly-samples#1785. * chore(generators): format (cherry picked from commit d503fbb) * fix: Correct errors in `HSV_SATURATION`, `HSV_VALUE` accessors (#7297) * fix: Correct errors in HSV_SATURATION, HSV_VALUE accessors Fix the comment / message errors noted in #7249 (comment) * chore: Add renamings for HSV_SATURATION, HSV_VALUE (cherry picked from commit 1bc4f67) * release: Update version number to 10.0.2 --------- Co-authored-by: Christopher Allen <cpcallen+git@google.com>
3 tasks
ericblackmonGoogle
added a commit
that referenced
this pull request
Jul 17, 2023
* fix(generators): Changes to exports and access controls for TypeScript compatibility (#7295) * fix(generators): Add missing declarations for Order enums * chore(generators): Remove spurious whitespace * fix(generators): Make provideFunction_ etc. public Remove the protected declaration on provideFunction_ and FUNCTION_NAME_PLACEHOLDER_ so they can be used from generator functions written in TypeScript. Not strictly part of #7283, but closely related and required to fixing the related issue RaspberryPiFoundation/blockly-samples#1785. * chore(generators): format (cherry picked from commit d503fbb) * fix: Correct errors in `HSV_SATURATION`, `HSV_VALUE` accessors (#7297) * fix: Correct errors in HSV_SATURATION, HSV_VALUE accessors Fix the comment / message errors noted in #7249 (comment) * chore: Add renamings for HSV_SATURATION, HSV_VALUE (cherry picked from commit 1bc4f67) * release: Update version number to 10.0.2 --------- Co-authored-by: Christopher Allen <cpcallen+git@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Developer errors/confusion caused by the removal of
HSV_SATURATIONandHSV_VALUEby PR #7077 despite them not having previously been formally deprecated.Proposed Changes
Restore these accessors but mark them as deprecated.
Reason for Changes
Reduce developer pain.
Test Coverage
Passes
npm test.Documentation
This was an undocumented and not-previously-promulgated change in Blockly v10.0.0. If we do not revert (via this PR or similar) we should at least issue an errata to the release notes.
Additional Information
DEPRECATION:
Blockly.HSV_SATURATIONandBlockly.HSV_VALUEare deprecated and will be removed in a future version of Blockly. UseBlockly.utils.colour.getHsvSaturation/Blockly.utils.colour.setHsvSaturationandBlockly.utils.colour.getHsvValue/Blockly.utils.colour.setHsvValueinstead.