release: v10.0.1#7270
Merged
ericblackmonGoogle merged 2 commits intomasterfrom Jul 10, 2023
Merged
Conversation
…#7249) * fix: Restore HSV_SATURATION and HSV_VALUE accessors Contrary to the notice at the top of the `Object.defineProperties` call, these were not actually marked as deprecated, and their removal in Blockly 10.0.0 constituted an avoidable zero-notice breaking change. * deprecate: Add deprecation notices for HSV_SATURATION and HSV_VALUE DEPRECATION: Blockly.HSV_SATURATION and Blockly.HSV_VALUE are deprecated and will be removed in a future version of Blockly. Use Blockly.colour.getHsvSaturation / Blockly.colour.setHsvSaturation and Blockly.colour.getHsvValue / Blockly.colour.setHsvValue instead. (cherry picked from commit a677355)
ericblackmonGoogle
requested review from
rachel-fenichel
and removed request for
a team
cpcallen
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Developer errors/confusion caused by the removal of
HSV_SATURATIONandHSV_VALUEby PR #7077 despite them not having previously been formally deprecatedProposed Changes
HSV_SATURATIONandHSV_VALUEaccessors and deprecate #7249