Make the instance buttons in Model Viewer truly unique#131
Merged
MilchRatchet merged 1 commit intoMay 12, 2026
Merged
Conversation
When hooked to RPCS3, it's possible for mobys to have the same mobyID. Since that's what was used to create the button's label, there were multiple buttons with the same label, which made ImGui unhappy and caused only one instance to be selectable. Fix by including the guaranteed unique globalID of elements as hidden text in the button label, which makes them unique to ImGui while still showing the same text as before.
Contributor
Author
|
p.s. I think it's actually a bug in the memory hook in that it shows some dead mobys as "alive". but I did not investigate this further |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When hooked to RPCS3, it's possible for mobys to have the same mobyID. Since that's what was used to create the button's label, there were multiple buttons with the same label, which made ImGui unhappy and caused only one instance to be selectable.
Fix by including the guaranteed unique globalID of elements as hidden text in the button label, which makes them unique to ImGui while still showing the same text as before.
While at it, also actually make use of string interpolation in one place that wanted to but did not.