fix: track core v2.5.8 — drop now-public poll declarations - #3
Merged
Conversation
Core v2.5.8 exports the poll object API (ray_poll_create, ray_runtime_get_poll, ray_runtime_set_poll) from the public rayforce.h. wrapper.h still hand-declared all three, and bindgen now fails on ray_poll_create — the public header types it ray_poll_t* where wrapper.h had void*, and the two conflict. Drop the three hand-declarations (they are redundant with the public header) and bump the pinned RAYFORCE_REF from v2.5.1 to v2.5.8 so a fresh crates.io build clones a core that actually exports them. ray_poll_create now binds as ray_poll_t* rather than void*, so ensure_poll casts the handle on the way into ray_runtime_set_poll, which still takes void*. Verified: cargo build + cargo test green against a local v2.5.8 checkout, and the embedding consumer (landing) builds and its scenario suite passes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core v2.5.8 exports the poll object API (ray_poll_create, ray_runtime_get_poll, ray_runtime_set_poll) from the public rayforce.h. wrapper.h still hand-declared all three, and bindgen now fails on ray_poll_create — the public header types it ray_poll_t* where wrapper.h had void*, and the two conflict.
Drop the three hand-declarations (they are redundant with the public header) and bump the pinned RAYFORCE_REF from v2.5.1 to v2.5.8 so a fresh crates.io build clones a core that actually exports them.
ray_poll_create now binds as ray_poll_t* rather than void*, so ensure_poll casts the handle on the way into ray_runtime_set_poll, which still takes void*.
Verified: cargo build + cargo test green against a local v2.5.8 checkout, and the embedding consumer (landing) builds and its scenario suite passes.