Skip to content

Fix date idate subtraction#7828

Merged
ben-schwen merged 4 commits into
masterfrom
fix_date_idate_sub
Jul 25, 2026
Merged

Fix date idate subtraction#7828
ben-schwen merged 4 commits into
masterfrom
fix_date_idate_sub

Conversation

@ben-schwen

Copy link
Copy Markdown
Member

Closes #7825
Follows #7827

@ben-schwen
ben-schwen force-pushed the fix_date_idate_sub branch from 708974b to 27bfb97 Compare July 21, 2026 16:49
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (46d0934) to head (b6bca2a).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7828   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          88       88           
  Lines       17234    17239    +5     
=======================================
+ Hits        17065    17070    +5     
  Misses        169      169           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MichaelChirico

Copy link
Copy Markdown
Member

Looks good at a glance. Let's merge the atime test first so we can see the performance change directly in the PR.

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
  • HEAD=fix_date_idate_sub much faster for Date-IDate subtraction regression in #7213
    Comparison Plot

Generated via commit b6bca2a

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 3 minutes and 3 seconds
Installing different package versions 50 seconds
Running and plotting the test cases 8 minutes and 59 seconds

@MichaelChirico

Copy link
Copy Markdown
Member

Hmm I'm still not seeing the right thing in the {atime} result, I reckon? I see 'Before' below the other timings!

@ben-schwen

Copy link
Copy Markdown
Member Author

Hmm I'm still not seeing the right thing in the {atime} result, I reckon? I see 'Before' below the other timings!

Good catch. Apparently and unfortunately we need to reregister more. Now the test LGTM
image

@MichaelChirico

Copy link
Copy Markdown
Member

Now we're cooking (funnily enough it does look to be catching up around N=1e7 👀 )

Comment thread R/IDateTime.R Outdated
Co-authored-by: Michael Chirico <chiricom@google.com>
@ben-schwen
ben-schwen merged commit 3376b44 into master Jul 25, 2026
12 checks passed
@ben-schwen
ben-schwen deleted the fix_date_idate_sub branch July 25, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Severe slowdown for Date - IDate inside outer() with R 4.6.1 and data.table 1.18.4

2 participants