Get other.Rraw running again in r-devel#7833
Open
MichaelChirico wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7833 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 88 88
Lines 17234 17234
=======================================
Hits 17065 17065
Misses 169 169 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Generated via commit 58ce9c4 Download link for the artifact containing the test results: ↓ atime-results.zip
|
MichaelChirico
force-pushed
the
other-attach-order
branch
from
July 24, 2026 06:05
5dde771 to
58ce9c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A few changes here:
attach.required=FALSEbut that's not present on R 3.5.0.print(<ggplot-obj>)works without error, so I refactored the tests to do that more directly.example()(described below).Without the update to
cedta()we get the telltalecedta()issues from here:data.table/inst/tests/other.Rraw
Lines 227 to 229 in fae95de
AIUI this is because of #7162 adding one more item on the call stack during execution of
example().Split off from #7832 as the actual debugging of package code should be done artisinally.