Skip to content

Support drop=TRUE in subset.data.table - #7860

Merged
MichaelChirico merged 2 commits into
masterfrom
subset-drop
Jul 30, 2026
Merged

Support drop=TRUE in subset.data.table#7860
MichaelChirico merged 2 commits into
masterfrom
subset-drop

Conversation

@MichaelChirico

Copy link
Copy Markdown
Member

Closes #7859

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (0d338a9) to head (42e4bd7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7860   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          88       88           
  Lines       17291    17292    +1     
=======================================
+ Hits        17121    17122    +1     
  Misses        170      170           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
  • HEAD=subset-drop much slower for transform improved in #5493
  • HEAD=subset-drop slower P<0.001 for DT[by,verbose=TRUE] improved in #6296
    Comparison Plot

Generated via commit 42e4bd7

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 3 minutes and 12 seconds
Installing different package versions 47 seconds
Running and plotting the test cases 5 minutes and 41 seconds

Comment thread inst/tests/tests.Rraw Outdated
Comment thread inst/tests/tests.Rraw Outdated

@ben-schwen ben-schwen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change LGTM. some minor test things

@ben-schwen

Copy link
Copy Markdown
Member

:shipit:

@MichaelChirico
MichaelChirico merged commit 6793af2 into master Jul 30, 2026
14 checks passed
@MichaelChirico
MichaelChirico deleted the subset-drop branch July 30, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

subset() method does not resepect drop=TRUE

2 participants