fix: Purge temp files#332
Closed
lorenzoverardo wants to merge 1 commit intoReVanced:devfrom
lorenzoverardo:fix-purge-option
Closed
fix: Purge temp files#332lorenzoverardo wants to merge 1 commit intoReVanced:devfrom lorenzoverardo:fix-purge-option
lorenzoverardo wants to merge 1 commit intoReVanced:devfrom
lorenzoverardo:fix-purge-option
Conversation
oSumAtrIX
reviewed
May 13, 2024
| // region Save | ||
| apk.copyTo(temporaryFilesPath.resolve(apk.name), overwrite = true).apply { | ||
| patcherResult.applyTo(this) | ||
| patcherResult.dexFiles.forEach{it.stream.close()} |
Member
There was a problem hiding this comment.
Maybe it.use {} should be used in the applyTo function in ReVanced Library instead so it auto closes after using the stream, but I am not sure if closing the streams is applyTo's job. I think a better approach would be to return files instead of opening streams to them so that one can open streams for it at any time
Member
|
The proposal above would need to be implemented in Patcher though, thanks for the PR regardless |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #327.
Closes streams so that files can be correctly deleted.