Skip to content

fix(Lightroom): Add Disable version check patch #6315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
+45 −0
Open

fix(Lightroom): Add Disable version check patch #6315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
10cc62d
fix: lightroom version bypass patch (allow 9.3.0 to open)
f1re4xx Nov 24, 2025
aba800c
fix: [lightroom patch] add patch description, simplify fingerprint
f1re4xx Nov 24, 2025
f2ea6c6
Apply suggestion from @oSumAtrIX
oSumAtrIX Nov 24, 2025
1ac1e5f
Update patches/src/main/kotlin/app/revanced/patches/lightroom/misc/by…
oSumAtrIX Nov 24, 2025
f3b10dd
fix: [lightroom patch] make implementation more clear
f1re4xx Nov 24, 2025
1db0507
fix: [lightroom patch] rename fingerprint
f1re4xx Nov 24, 2025
6d3506c
Apply suggestions from code review
oSumAtrIX Nov 25, 2025
ab6c85c
fix: [lightroom patch] add description to DisableVersionCheck
f1re4xx Nov 25, 2025
b882a33
Apply suggestion from @oSumAtrIX
oSumAtrIX Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions patches/api/patches.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,10 @@ public final class app/revanced/patches/lightroom/misc/premium/UnlockPremiumPatc
public static final fun getUnlockPremiumPatch ()Lapp/revanced/patcher/patch/BytecodePatch;
}

public final class app/revanced/patches/lightroom/misc/version/DisableVersionCheckPatchKt {
public static final fun getDisableVersionCheckPatch ()Lapp/revanced/patcher/patch/BytecodePatch;
}

public final class app/revanced/patches/memegenerator/detection/license/LicenseValidationPatchKt {
public static final fun getLicenseValidationPatch ()Lapp/revanced/patcher/patch/BytecodePatch;
}
Expand Down
23 changes: 23 additions & 0 deletions ...kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/DisableVersionCheckPatch.kt
View file
Open in desktop
Copy link
Member

@oSumAtrIX oSumAtrIX Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the patch can be directly placed in misc package. The file name should start with uppercase

Copy link
Author

@f1re4xx f1re4xx Nov 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I placed it similarly to the two existing patches

Copy link
Member

@oSumAtrIX oSumAtrIX Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure but the file still seems in the wrong package

Copy link
Member

@oSumAtrIX oSumAtrIX Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name should be lowercase "versioncheck" for example

Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
package app.revanced.patches.lightroom.misc.version

import app.revanced.patcher.extensions.InstructionExtensions.replaceInstruction
import app.revanced.patcher.patch.bytecodePatch
import com.android.tools.smali.dexlib2.Opcode

@Suppress("unused")
val DisableVersionCheckPatch = bytecodePatch(
name = "Disable version check",
Copy link
Member

@oSumAtrIX oSumAtrIX Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a description with the purpose of the patch

Copy link
Author

@f1re4xx f1re4xx Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description added

description = "Disables the server-side version check that prevents the app from starting.",
) {
compatibleWith("com.adobe.lrmobile"("9.3.0"))

execute {
refreshRemoteConfigurationFingerprint.method.apply {
val igetIndex = refreshRemoteConfigurationFingerprint.patternMatch!!.endIndex

// This value represents the server command to clear all version restrictions.
const val STATUS_FORCE_RESET_HEX = "-0x2";
replaceInstruction(igetIndex, "const/4 v1, $STATUS_FORCE_RESET_HEX")
}
}
}
18 changes: 18 additions & 0 deletions ...es/src/main/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/Fingerprints.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package app.revanced.patches.lightroom.misc.version

import app.revanced.patcher.fingerprint
import com.android.tools.smali.dexlib2.AccessFlags
import com.android.tools.smali.dexlib2.Opcode

internal val refreshRemoteConfigurationFingerprint = fingerprint {
accessFlags(AccessFlags.PUBLIC, AccessFlags.STATIC)
strings(
"com.adobe.lrmobile.denylisted_version_set_key",
"com.adobe.lrmobile.app_min_version_key"
)
opcodes(
Opcode.INVOKE_STATIC,
Opcode.MOVE_RESULT_OBJECT,
Opcode.IGET, // Overwrite this instruction to disable the check.
)
}