Skip to content

Conversation

@taion
Copy link
Contributor

@taion taion commented Aug 5, 2016

No description provided.

@taion
Copy link
Contributor Author

taion commented Aug 5, 2016

Making use of https://github.com/babel/babel/releases/tag/v6.13.0 to simplify our Babel configuration considerably.

@timdorr
Copy link
Member

timdorr commented Aug 5, 2016

Neat. But I'm not sure I like the indirection to another file somewhere else. Why not just keep the envs and declare the options that way? Less code, more config.

@taion
Copy link
Contributor Author

taion commented Aug 5, 2016

The main downside of doing it that way is repeating "es2015-{whatever}", "stage-1" everywhere, and ending up with potentially broken config otherwise.

The other downside is that, because we can't apply the standard es2015 transform, as configured, unless you explicitly set the environment, you can't actually run any of our code.

@taion
Copy link
Contributor Author

taion commented Aug 9, 2016

@timdorr Do you feel strongly that we should get rid of the custom es2015 preset with the BABEL_ENV conditional?

@timdorr
Copy link
Member

timdorr commented Aug 9, 2016

Not so much that it really matters. Let's just do it.

@timdorr timdorr merged commit b01a258 into master Aug 9, 2016
@timdorr timdorr deleted the update-babel branch August 9, 2016 03:20
@taion
Copy link
Contributor Author

taion commented Aug 9, 2016

Okay, thanks. I'm going to try to make this a pattern in a bunch of places, so hopefully it will be less unfamiliar.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants