Update Babel config #3703

Merged
merged 4 commits into from Aug 9, 2016

Projects

None yet

2 participants

@taion
Contributor
taion commented Aug 5, 2016

No description provided.

@taion taion Update Babel config
7f23f28
@taion
Contributor
taion commented Aug 5, 2016

Making use of https://github.com/babel/babel/releases/tag/v6.13.0 to simplify our Babel configuration considerably.

@timdorr
Collaborator
timdorr commented Aug 5, 2016

Neat. But I'm not sure I like the indirection to another file somewhere else. Why not just keep the envs and declare the options that way? Less code, more config.

@taion
Contributor
taion commented Aug 5, 2016

The main downside of doing it that way is repeating "es2015-{whatever}", "stage-1" everywhere, and ending up with potentially broken config otherwise.

The other downside is that, because we can't apply the standard es2015 transform, as configured, unless you explicitly set the environment, you can't actually run any of our code.

taion added some commits Aug 5, 2016
@taion taion Update for Babel 6.13.2
ed668dc
@taion taion Lint all the things
96b73ef
@taion taion __DEV__ is a non-writable global
5535faf
@taion
Contributor
taion commented Aug 9, 2016

@timdorr Do you feel strongly that we should get rid of the custom es2015 preset with the BABEL_ENV conditional?

@timdorr
Collaborator
timdorr commented Aug 9, 2016

Not so much that it really matters. Let's just do it.

@timdorr timdorr merged commit b01a258 into master Aug 9, 2016

3 checks passed

codecov/patch Coverage not affected when comparing 78359e6...5535faf
Details
codecov/project 93.91% (+0.00%) compared to 78359e6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@timdorr timdorr deleted the update-babel branch Aug 9, 2016
@taion
Contributor
taion commented Aug 9, 2016

Okay, thanks. I'm going to try to make this a pattern in a bunch of places, so hopefully it will be less unfamiliar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment