Reset species output paths when deleting all species jobs#686
Merged
Conversation
alongd
force-pushed
the
reset_output_paths
branch
from
435ab66 to
864e5fe
Compare
Codecov Report
@@ Coverage Diff @@
## main #686 +/- ##
=======================================
Coverage 73.18% 73.19%
=======================================
Files 99 99
Lines 26524 26525 +1
Branches 5547 5548 +1
=======================================
+ Hits 19412 19414 +2
Misses 5771 5771
+ Partials 1341 1340 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we
delete_all_species_jobs, for example after switching a TS guess to something better and we no longer need the sp, freq, etc jobs of the previous TS, we must also reset theoutputdict of theSchedulerobject, so that all paths are empty. Note that forircwe have two paths, forward and reverse, so we treat it differently (see here the structure of the output dict)