ND scans: rebased on main, with finalization-crash and pipe_planner fixes - #930
Open
alongd wants to merge 5 commits into
Open
ND scans: rebased on main, with finalization-crash and pipe_planner fixes#930alongd wants to merge 5 commits into
alongd wants to merge 5 commits into
Conversation
Contains pure scan-surface helpers
Scheduler.__init__ calls run_scan_jobs() from its per-species restart loop,
and run_scan_jobs dereferences self.pipe_planner via try_pipe_rotor_scans_1d().
The planner was constructed after that loop, so restarting a project with
pending 1D rotor scans raised:
AttributeError: 'Scheduler' object has no attribute 'pipe_planner'
Construction now happens before the restart loop. Both PipeCoordinator and
PipePlanner only store references in __init__, so early construction is safe.
This is a latent bug on main (main:464/487/511 call run_scan_jobs; main:521
assigns pipe_planner); it was surfaced by the ND scan functional tests, which
are the first tests to exercise that construction path.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
|
|
||
| import arc.parser.parser as parser | ||
| import arc.scheduler as sched_module |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
==========================================
+ Coverage 63.40% 64.18% +0.78%
==========================================
Files 114 115 +1
Lines 38342 39158 +816
Branches 10030 10183 +153
==========================================
+ Hits 24309 25135 +826
+ Misses 11116 11028 -88
- Partials 2917 2995 +78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR supersedes/complements #855. It is #855's four commits (
Added the ND Scan module,Added directed scan to xTB job adapter,Added ND scan functionalities to plotter,Adaptations to Scheduler) rebased onto currentmain(263 commits of drift since #855 was opened), plus two additional fixes:finalize_directed_scan_results(see review comment on Refactor ND scan subsystem with adaptive sparse 2D sampling, surface validation, and coupling classification #855 for details).pipe_plannerinitialization-order bug inScheduler.__init__.#855 should not be force-pushed or rebased in place — its branch (
nd_scans) is currently checked out in a live, long-running working session with uncommitted local patches, and rewriting it there would destroy that work. This PR exists so the rebased/fixed history can be reviewed and landed without touchingnd_scans.Detailed review findings (conflict-resolution notes, two latent bugs found on
main, the finalization-crash fix, and several design questions worth discussing) are posted as a comment on #855.Closes/relates to #855.
Test plan