Skip to content

2.x: Elide ObservableWrapper for empty and never.#4287

Merged
akarnokd merged 1 commit into
ReactiveX:2.xfrom
JakeWharton:jw/elide-wrapper
Aug 6, 2016
Merged

2.x: Elide ObservableWrapper for empty and never.#4287
akarnokd merged 1 commit into
ReactiveX:2.xfrom
JakeWharton:jw/elide-wrapper

Conversation

@JakeWharton

Copy link
Copy Markdown
Contributor

No description provided.

@JakeWharton JakeWharton changed the title Elide ObservableWrapper for empty and never. 2.x: Elide ObservableWrapper for empty and never. Aug 6, 2016
@JakeWharton

Copy link
Copy Markdown
Contributor Author

Not sure whether the use of create is intentional or not internally. As of right now it's just a trampoline/indirection to subscribeActual so if extending Observable is fine, I can go through and eliminate all of these.

@codecov-io

codecov-io commented Aug 6, 2016

Copy link
Copy Markdown

Current coverage is 69.61% (diff: 100%)

Merging #4287 into 2.x will decrease coverage by 0.01%

@@                2.x      #4287   diff @@
==========================================
  Files           419        419          
  Lines         30632      30632          
  Methods           0          0          
  Messages          0          0          
  Branches       4935       4935          
==========================================
- Hits          21331      21325     -6   
- Misses         7219       7227     +8   
+ Partials       2082       2080     -2   

Powered by Codecov. Last update a4fb7da...66abf1d

@akarnokd akarnokd added this to the 2.0 RC 1 milestone Aug 6, 2016
@akarnokd

akarnokd commented Aug 6, 2016

Copy link
Copy Markdown
Member

👍

@akarnokd akarnokd merged commit 2d36c7b into ReactiveX:2.x Aug 6, 2016
@JakeWharton JakeWharton deleted the jw/elide-wrapper branch August 20, 2016 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants