Skip to content

2.x: add new methods to Maybe, Observable and Single from 4481#4488

Merged
akarnokd merged 2 commits into
ReactiveX:2.xfrom
akarnokd:MaybeOps906_1
Sep 6, 2016
Merged

2.x: add new methods to Maybe, Observable and Single from 4481#4488
akarnokd merged 2 commits into
ReactiveX:2.xfrom
akarnokd:MaybeOps906_1

Conversation

@akarnokd

@akarnokd akarnokd commented Sep 6, 2016

Copy link
Copy Markdown
Member

This PR adds just the new methods from #4481 to allow a much cleaner change of return types later on.

@akarnokd akarnokd added this to the 2.0 RC 3 milestone Sep 6, 2016
Comment thread src/main/java/io/reactivex/Maybe.java Outdated
// ------------------------------------------------------------------

/**
* Waits in a blocking fashion until the current Maybe signals a success value (which is returned) or

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null, not defaultValue

@JakeWharton

Copy link
Copy Markdown
Contributor

👍

@codecov-io

codecov-io commented Sep 6, 2016

Copy link
Copy Markdown

Current coverage is 77.79% (diff: 8.16%)

Merging #4488 into 2.x will decrease coverage by 0.36%

@@                2.x      #4488   diff @@
==========================================
  Files           497        500     +3   
  Lines         33772      33909   +137   
  Methods           0          0          
  Messages          0          0          
  Branches       5303       5325    +22   
==========================================
- Hits          26396      26378    -18   
- Misses         5409       5554   +145   
- Partials       1967       1977    +10   

Powered by Codecov. Last update 928e437...344af8d

@akarnokd

akarnokd commented Sep 6, 2016

Copy link
Copy Markdown
Member Author

Updated with corrections.

@akarnokd akarnokd merged commit ff3c5d0 into ReactiveX:2.x Sep 6, 2016
@akarnokd akarnokd deleted the MaybeOps906_1 branch September 6, 2016 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants