Skip to content

4.x: Unit test lambdaification 16 of N#8157

Merged
akarnokd merged 2 commits into
ReactiveX:4.xfrom
akarnokd:4xUnitTestLambdas16
Jun 22, 2026
Merged

4.x: Unit test lambdaification 16 of N#8157
akarnokd merged 2 commits into
ReactiveX:4.xfrom
akarnokd:4xUnitTestLambdas16

Conversation

@akarnokd

Copy link
Copy Markdown
Member

Will go over the unit tests in ASCII order of the classpath and classes.

IntelliJ: Inspect -> RedundantCast, Inspect -> Anonymous type can be replaced by lambda
Search regexp: new\s+\w+(?:\s*<(?:[\s\w<>(\[\])?,.?]|\s*<[\s\w<>(\[\])?,.?]*>)*>)?\s*\([^)]*\)\s*\{

/* NFI */ = Not Functional Interface so break the regexp pattern

If you complain instead of proposing a PR about "why not convert to method references" you'll be banned.

Related: #8080

@akarnokd akarnokd added this to the 4.0 milestone Jun 22, 2026
@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.81 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

src/jmh/java/io/reactivex/rxjava4/core/TakeUntilPerf.java: 4.967
src/jmh/java/io/reactivex/rxjava4/core/ToFlowablePerf.java: 4.966
src/jmh/java/io/reactivex/rxjava4/xmapz/FlowableConcatMapMaybePerf.java: 5.133
src/jmh/java/io/reactivex/rxjava4/xmapz/FlowableConcatMapSinglePerf.java: 5.128
src/jmh/java/io/reactivex/rxjava4/xmapz/FlowableSwitchMapCompletablePerf.java: 5.119
src/jmh/java/io/reactivex/rxjava4/xmapz/FlowableSwitchMapMaybeEmptyPerf.java: 5.145
src/jmh/java/io/reactivex/rxjava4/xmapz/FlowableSwitchMapMaybePerf.java: 5.139
src/jmh/java/io/reactivex/rxjava4/xmapz/FlowableSwitchMapSinglePerf.java: 5.132
src/jmh/java/io/reactivex/rxjava4/xmapz/ObservableConcatMapMaybeEmptyPerf.java: 5.122
src/jmh/java/io/reactivex/rxjava4/xmapz/ObservableFlatMapMaybeEmptyPerf.java: 5.115
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableMergeTest.java: 4.644
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableOnBackpressureDropTest.java: 4.700
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowablePublishTest.java: 4.530
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRefCountTest.java: 4.571
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRepeatTest.java: 4.733
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableReplayEagerTruncateTest.java: 4.741
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableReplayTest.java: 4.660
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRetryTest.java: 4.521
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRetryWithPredicateTest.java: 4.657
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSampleTest.java: 4.785

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.81 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

src/jmh/java/io/reactivex/rxjava4/core/TakeUntilPerf.java: 4.967
src/jmh/java/io/reactivex/rxjava4/core/ToFlowablePerf.java: 4.966
src/jmh/java/io/reactivex/rxjava4/xmapz/FlowableConcatMapMaybePerf.java: 5.133
src/jmh/java/io/reactivex/rxjava4/xmapz/FlowableConcatMapSinglePerf.java: 5.128
src/jmh/java/io/reactivex/rxjava4/xmapz/FlowableSwitchMapCompletablePerf.java: 5.119
src/jmh/java/io/reactivex/rxjava4/xmapz/FlowableSwitchMapMaybeEmptyPerf.java: 5.145
src/jmh/java/io/reactivex/rxjava4/xmapz/FlowableSwitchMapMaybePerf.java: 5.139
src/jmh/java/io/reactivex/rxjava4/xmapz/FlowableSwitchMapSinglePerf.java: 5.132
src/jmh/java/io/reactivex/rxjava4/xmapz/ObservableConcatMapMaybeEmptyPerf.java: 5.122
src/jmh/java/io/reactivex/rxjava4/xmapz/ObservableFlatMapMaybeEmptyPerf.java: 5.115
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableMergeTest.java: 4.644
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableOnBackpressureDropTest.java: 4.700
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowablePublishTest.java: 4.530
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRefCountTest.java: 4.571
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRepeatTest.java: 4.733
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableReplayEagerTruncateTest.java: 4.741
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableReplayTest.java: 4.660
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRetryTest.java: 4.521
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableRetryWithPredicateTest.java: 4.657
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableSampleTest.java: 4.785

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@akarnokd akarnokd added the Test label Jun 22, 2026
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.73%. Comparing base (55ef9d2) to head (6eb4af0).

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8157      +/-   ##
============================================
+ Coverage     98.69%   98.73%   +0.03%     
- Complexity     6934     6935       +1     
============================================
  Files           773      773              
  Lines         48990    48990              
  Branches       6586     6586              
============================================
+ Hits          48353    48369      +16     
+ Misses          462      454       -8     
+ Partials        175      167       -8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akarnokd akarnokd merged commit 5f3e76b into ReactiveX:4.x Jun 22, 2026
6 checks passed
@akarnokd akarnokd deleted the 4xUnitTestLambdas16 branch June 22, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant