4.x: Streamable API: DispatchStreamProcessor & other improvements#8217
Merged
Conversation
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.586 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #8217 +/- ##
============================================
- Coverage 98.68% 98.68% -0.01%
- Complexity 7026 7070 +44
============================================
Files 809 810 +1
Lines 49714 49855 +141
Branches 6719 6749 +30
============================================
+ Hits 49060 49197 +137
- Misses 458 460 +2
- Partials 196 198 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.586 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New types
StreamerInputRepresents an awaitable push side of signaling items and terminal states.
ℹ️ We might rename this to
StreamObserverorStreamSubscriber?StreamProcessorCombines a
Streamableand aStreamerInputto provide a similar interface toSubjectandFlow.Processors for theStreamableworld.DispatchStreamProcessorA publishing / multicasting processor where pushing events have to be awaited until they go through to all current
Streamers (or fall through if there are none).Test API improvements
TestSubscriber/TestObserver+awaitOnSubscribeCreated a latched await for receiving
onSubscribeevents because in theStreamableworld,subscribeandtestrun on a background thread and thus the whole lifecycle is shifted in time. This call will make sure the upstream reached a point where it calledonSubscribe.Tests updated accordingly.
TestSubscriber/TestObserver+awaitCount(int atLeast, long timeoutMillis, long sleepMillis)The plain
awaitCount(int atLeast)was introduced a while ago with predefined 5000 milliseconds timeout and 10 sleeps. This overload makes the times configurable for faster test execution, especially if the call was supposed to fail.Bugfixes
Streamable.subscribe(Subscriber)did not properly wire up the cancellation mechanisms.