fix: improve the g2p error toast so the user can interact with it#486
Merged
fix: improve the g2p error toast so the user can interact with it#486
Conversation
- let it live longer - don't dismiss on hover or click, so you can cut and paste contents out of it - give it a close button so you can still dismiss it
|
Review changes with Changed Files
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing #483 by PRs doing one thing each, as I should have done in the first place...
This one improves the interaction with the g2p error toast:
How to test?
enter
asdf 123 asdf : 1234in the text box, and see:Confidence?
high