fix: hide g2p warnings from the GUI, show them in console#496
Merged
Conversation
|
Review changes with Changed Files
|
Contributor
|
joanise
force-pushed
the
dev.ej/hide-g2p-warnings
branch
from
753f2c4 to
52a4074
Compare
joanise
force-pushed
the
dev.ej/hide-g2p-warnings
branch
from
52a4074 to
e9bf251
Compare
marctessier
approved these changes
Dec 19, 2025
Collaborator
marctessier
left a comment
marctessier
left a comment
There was a problem hiding this comment.
Works great! gp2 Warning were in console logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Marc noticed that sometimes our toast about g2p warnings can get really long, especially when aligning a long text, but it's not actually informative. 99% of users won't care that this or that word had to fall back to
undor even understand what that means.In brainstorming, Marc and I figured it would make more sense to
console.log()the RAS web api log for the advanced user who wants to see them, but keep them out of the GUI because they're just visual noise to most users.So that's what this PR does
Feedback sought?
I guess vetting that this idea makes sense.
Priority?
normal
Tests added?
nope
How to test?
test asdf testin the textengforasdfis not diplayed, but if you open the console you'll see the full assemble log including the g2p warnings with headerRAS Web API assemble/ log:.Confidence?
high
Version change?
no