Fix our CI workflow on Windows#557
Merged
Merged
Conversation
|
Review changes with |
…557) https://docs.cypress.io/app/references/changelog#15-16-0 release notes say: > Fixed an issue on Node 24.16.0+ and Node 26.1.0+ where installing > Cypress could silently extract only the first file from the binary > archive, causing the test runner to fail to launch with a "Cypress > binary is missing" error. Addresses #33891. Addressed in #33887. When we bumped to 24.16.0 in CI, that broke the Windows worflow. I'm not sure why it didn't break the Linux workflow, but meh, not going to hunt that down too far...
Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.5 to 0.2.7. - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.2.5...v0.2.7) --- updated-dependencies: - dependency-name: tmp dependency-version: 0.2.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
joanise
force-pushed
the
dev.ej/ci-fix-win
branch
from
791019e to
061dc5d
Compare
Contributor
|
Member
Author
So much work to find it! 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Fix test-for-windows
Was broken due to recent incompatibility between zip handlers and the latest node.
The latest cypress release https://docs.cypress.io/app/references/changelog#15-16-0 reports a fix for the problem as the first entry of the Bugfixes list:
At the same time, I'm re-applying #555 since it's no longer breaking CI. I think that was in fact unrelated, cypress was most likely the problem from the beginning.
Fixes?
broken Windows CI workflow
Feedback sought?
sanity check
Priority?
medium high
How to test?
look at the CI results for "Run tests on Windows"
Confidence?
high
Version change?
no