Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
Move the prod dependencies to our nrc-ilt variants of panphon and editdistance, in preparation for merging NRC-ILT/g2p#465
Side tasks:
Not included: I did not add Python 3.14 to matrix testing yet. That will require NRC-ILT/g2p#466
Feedback sought?
sanity check
Priority?
should be merged as right after NRC-ILT/g2p#465 is merged.
Tests added?
add macOS to CI to validate impact, but really it's just the Heroku tests that are relevant, so I suppose the two changes are not genuinely related... :)
Interestingly, the heroku CI workflow installs ilt-editdistance and ilt-panphon, then install the original editdistance and panphon because those are still required by g2p@main, yes everything works fine. Once we merge NRC-ILT/g2p#465 the two original packages should not longer get installed.
How to test?
CI does it.
Confidence?
high
Version change?
not really needed but we're kinda due, so it might be a good idea to do a patch bump by now