Skip to content

Conversation

@joanise
Copy link
Member

@joanise joanise commented Nov 18, 2025

PR Goal?

Move the prod dependencies to our nrc-ilt variants of panphon and editdistance, in preparation for merging NRC-ILT/g2p#465

Side tasks:

  • add MacOS to matrix testing (to exercise these nrc-ilt variants)
  • fix a sporadic licensecheck error with setuptools (which blocked a test version of this PR)
  • fix a flake8 warning in accuracy.py (yeah, this one is not related...)

Not included: I did not add Python 3.14 to matrix testing yet. That will require NRC-ILT/g2p#466

Feedback sought?

sanity check

Priority?

should be merged as right after NRC-ILT/g2p#465 is merged.

Tests added?

add macOS to CI to validate impact, but really it's just the Heroku tests that are relevant, so I suppose the two changes are not genuinely related... :)

Interestingly, the heroku CI workflow installs ilt-editdistance and ilt-panphon, then install the original editdistance and panphon because those are still required by g2p@main, yes everything works fine. Once we merge NRC-ILT/g2p#465 the two original packages should not longer get installed.

How to test?

CI does it.

Confidence?

high

Version change?

not really needed but we're kinda due, so it might be a good idea to do a patch bump by now

@semanticdiff-com
Copy link

semanticdiff-com bot commented Nov 18, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  misc-utils/accuracy.py  100% smaller
  .github/workflows/tests.yml  64% smaller
  .github/workflows/matrix-tests.yml  41% smaller
  requirements.txt Unsupported file format

@joanise joanise requested a review from roedoejet November 18, 2025 18:10
@github-actions
Copy link
Contributor

CLI load time: 0:00.04
Pull Request HEAD: 925c6e75a0ad4bcebb052329c0b674f2a700efbc
No imports take more than 0.1 s.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.59%. Comparing base (33f47db) to head (925c6e7).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files          22       22           
  Lines        1885     1885           
  Branches      309      309           
=======================================
  Hits         1670     1670           
  Misses        178      178           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joanise joanise merged commit fc7a0ea into main Nov 19, 2025
26 checks passed
@joanise joanise deleted the dev.ej/ilt-panphon branch November 19, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants