Skip to content

build: make Dockerfile compatible with podman and other fixes#291

Merged
joanise merged 2 commits intomainfrom
dev.ej/podman-compat
Dec 5, 2025
Merged

build: make Dockerfile compatible with podman and other fixes#291
joanise merged 2 commits intomainfrom
dev.ej/podman-compat

Conversation

@joanise
Copy link
Copy Markdown
Member

@joanise joanise commented Dec 4, 2025

PR Goal?

make our Dockerfile compatible with podman for the orange DAC

Fixes?

  • update .dockerignore to include all venv
  • remove SHELL=, not supported by podman, not needed anyway since it just redeclared the default
  • (slightly) better documentation
  • remove py3-numpy apk package since pip then just reinstalls a different version
  • remove cloning g2p since requirements.txt already get g2p@main from github

Feedback sought?

rubber stamping

Priority?

low

Tests added?

no

How to test?

podman build --tag ras .
podman run --rm ras

Confidence?

high

Version change?

no

@semanticdiff-com
Copy link
Copy Markdown

Review changes with  SemanticDiff

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 4, 2025

CLI load time: 0:00.04
Pull Request HEAD: 3890bb452e6de5e2a8862b785c5336e7d5bb7f89
No imports take more than 0.1 s.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.59%. Comparing base (c97f5f2) to head (3890bb4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files          22       22           
  Lines        1885     1885           
  Branches      309      309           
=======================================
  Hits         1670     1670           
  Misses        178      178           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from dev.ej/ilt-panphon-0.21.4 to main December 4, 2025 21:34
@joanise joanise merged commit 0a14465 into main Dec 5, 2025
8 checks passed
@joanise joanise deleted the dev.ej/podman-compat branch December 5, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant