test(goldens): regenerate country-field state goldens for the neutral hint (#825)#832
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
stagingVisual Regression is red: #825 ("neutralize the misleading hint") changed the country-fieldcountryHintfrom "Schweiz"/"Switzerland" to "Land auswählen"/"Select country" and regenerated the default country goldens, but the state goldens added by #828 (nationality) and #829 (registration wizard) — which render the empty country field with the old hint — were merged around the same time and were not regenerated for #825's change. On current staging they still show "Schweiz", so they no longer match the rendered UI.Fix
Regenerated exactly the 11 stale state goldens against current
staging(with #825's new hint). No test/lib code changed — only the PNG baselines:kyc_nationality_page_{submit_loading, submit_failure, validation_error}kyc_registration_page_{address_step, tax_step, forwarding_failed_snackbar, submit_failure_snackbar}kyc_registration_personal_step_{account_type_open, phone_prefix_open, validation_error}kyc_registration_address_step_validation_errorEach now renders the neutral "Land auswählen" placeholder. The other state goldens in those files (dropdown-open, country-loading, country-error) don't show the hint and are unchanged.
Verification
Regenerated on the CI-identical toolchain (Flutter 3.41.6), two
--update-goldensruns byte-identical;git diffshows exactly these 11 PNGs and nothing else;flutter analyzeclean; the four affected golden test files pass against the new baselines. This restoresstagingto green.