fix: upgrade mobile_scanner to 7.4.0 for arm64 iOS-26 simulator support#875
Merged
Merged
Conversation
mobile_scanner 5.2.3 depended on GoogleMLKit, whose frameworks ship no arm64-iphonesimulator slice. On the arm-only iOS 26 simulator (Rosetta removed by Apple), the app could neither build nor run, breaking the handbook-flow CI with "Framework 'Pods_Runner' not found". 7.4.0 drops GoogleMLKit for Apple's native Vision API and builds/runs natively on arm64 simulators. Migrate the two errorBuilder call sites to the new 2-arg signature, and give QrScannerView a compact, textScale-safe default error placeholder so 7.x's taller default no longer overflows send_recipient_page's bounded layout at large text sizes.
…n tests mobile_scanner 7.x subscribes to a new 'dev.steenbakker.mobile_scanner/scanner/deviceOrientation' EventChannel that 5.2.3 did not have. The shared golden-test stub only handled the method + barcode-event channels, so the scanner-rendering golden tests threw MissingPluginException on listen/cancel. Add a no-op stream handler for it, mirroring the existing event-channel stub.
TaprootFreak
marked this pull request as ready for review
July 23, 2026 08:14
Contributor
Author
|
Ready for review — this went through 2 review passes to zero code findings.
Validated on the branch head: Tier 3 handbook flows (iOS build + 26 Maestro flows) and RealUnit Build (analyze/test, visual regression, coverage floor, BitBox) both green — this is the check that was failing the staging→develop promote. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mobile_scanner 5.2.3depends on GoogleMLKit, whose frameworks ship no arm64-iphonesimulator slice. On GitHub's arm64 macOS runners the iOS 26 simulator is arm-only (Apple removed Rosetta for the iOS 26 simulator), so the app could neither build nor run there — breaking thetier3-handbookCI withFramework 'Pods_Runner' not found. This is what red-flags the staging→develop promote.Fix
Upgrade
mobile_scannerto 7.4.0, which drops GoogleMLKit for Apple's native Vision API → the app builds and installs/launches natively on arm64 iOS 26.5 simulators.errorBuildercall sites to 7.x's 2-arg signature (dropped the unusedWidget? child).QrScannerViewnow supplies a compact, textScale-safe default error placeholder (icon-only) so 7.x's taller default no longer overflowssend_recipient_page's boundedExpandedat large accessibility text sizes.deviceOrientationevent channel in the golden-test helper, plus a focused widget test asserting the default placeholder stays overflow-safe atTextScaler.linear(3.0).Verification
flutter build ios --simulator --debug→ succeeds;simctl install+launchon iPhone 17 / iOS 26.5 → succeeds (no arch error, app renders).flutter analyzeclean;flutter test --exclude-tags golden→ all pass.Note on the scanner backend
The iOS scan backend changes GoogleMLKit → Apple Vision. The app only consumes
Barcode.rawValue, so Dart-side handling is unchanged. QR-decode parity between the two backends is architecturally expected (both fully support the QR symbology) but has not been verified against a live camera — the scanner is@no-integration-testand cannot run in CI, so a device smoke-test (bare address, checksummed address,ethereum:URI, LNURL) is worth doing before release.