Skip to content

01a0243f - Display share-token geo-filter from country API - #929

Closed
TaprootFreak wants to merge 5 commits into
stagingfrom
docs/handbook-share-token-geo-filter
Closed

01a0243f - Display share-token geo-filter from country API#929
TaprootFreak wants to merge 5 commits into
stagingfrom
docs/handbook-share-token-geo-filter

Conversation

@TaprootFreak

@TaprootFreak TaprootFreak commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

EN:
Handbook spec G on handbook.realunit.app renders the share-token geo-filter from GET /v1/country.
No country rows are stored in this repo; the DFX country table is the only source.
Missing Legal cells stay open. Crimea, Donetsk, and Luhansk remain a territorial addendum.
No goldens or screenshot slots change.

DE:
Handbook-Spec G auf handbook.realunit.app zeigt den Geo-Filter aus GET /v1/country.
In diesem Repo liegen keine Länderzeilen; Quelle ist nur die DFX-country-Tabelle.
Zellen ohne Legal-Wert bleiben offen. Krim, Donezk und Luhansk bleiben ein territoriales Addendum.
Goldens und Screenshot-Slots ändern sich nicht.

Details

Live fetch of https://api.dfx.swiss/v1/country. Classification fields live under realunit on each country. Visible only after the backend migration is deployed.

Add lettered spec G with one table over every DFX country row (250).
Residence and nationality follow Legal 2026-08-18; IP, tax residency, and
grandfathering stay open until Legal fills those cells.
@TaprootFreak
TaprootFreak marked this pull request as ready for review August 21, 2026 12:48
@TaprootFreak
TaprootFreak marked this pull request as draft August 21, 2026 12:48
@TaprootFreak
TaprootFreak marked this pull request as ready for review August 21, 2026 12:49
@TaprootFreak

Copy link
Copy Markdown
Contributor Author

EN:
Ready after 1 review pass.
Documents the share-token geo-filter as one table over every DFX country, with residence and nationality filled and IP, tax residency, and grandfathering left open for Legal.

DE:
Bereit nach 1 Review-Durchlauf.
Dokumentiert den Geo-Filter für den Aktientoken als eine Tabelle über jedes DFX-Land, mit ausgefülltem Wohnsitz und Nationalität und offenen Zellen für IP, Steueransässigkeit und Grandfathering.

Details

PR-review pass 1: quality and logic both complete with zero defects counted.

Quality reported two items that were rejected against the spec, not counted as defects:

  • The table is per country-as-attribute by design; the person-level nationality exception is stated in the intro (OR), not as a collapsed access cell.
  • "Brokerbot" is the public distribution channel, not a private repository name.

CI at head d2b7ce4: Analyze & Test pass, Coverage Floor Gate pass, Visual Regression pass, BitBox quirks audit pass, Handbook Build Check pass. Maestro handbook flows skipped by path filter (docs-only). Mergeable: MERGEABLE. No open review threads.

The 250-row copy is gone. Spec G loads GET /v1/country so the handbook
only displays what the DFX country table stores.
@TaprootFreak
TaprootFreak marked this pull request as draft August 21, 2026 18:59
Drop the duplicate tbody, the hardcoded 250-row placeholder, and map
missing realunit fields as open instead of inventing yes/no.
@TaprootFreak TaprootFreak changed the title 01a0243f - Document share-token geo-filter per DFX country 01a0243f - Display share-token geo-filter from country API Aug 21, 2026
Spec G maps the PascalCase country API values and refuses a partial table.
data-res-class now matches the existing lowercase CSS attribute selectors.
@TaprootFreak

Copy link
Copy Markdown
Contributor Author

EN:
Closing this draft; the live handbook table landed in #930.

DE:
Dieser Draft wird geschlossen; die Live-Tabelle im Handbook ist über #930 da.

Details

staging already contains the live GET /v1/country table from #930 (merged 2026-08-22). This draft would duplicate that change and is one commit behind staging. Backend geo-filter logic is in develop via DFXswiss/backend#5133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant