01a033fb - test(buy): pin EUR quotes to the EUR settlement IBAN - #938
Merged
Conversation
EUR buy quotes must send currency EUR and display the EUR IBAN from the API response, not a leftover CHF IBAN. Tests now pin that contract from the DTO through confirm to the payment-details card.
The EUR IBAN display tests injected success without pressing confirm. A tap on the EUR quote now verifies confirmPayment is still invoked.
Contributor
Author
|
EN: DE: DetailsReview rounds until 0 findings: 2 (first pass asked for an EUR confirm tap; second pass was clean). Gates:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
These tests pin that a EUR buy sends currency EUR and shows the EUR settlement IBAN from the quote, not a leftover CHF IBAN.
Production buy code is unchanged: it already forwards the selected currency and renders the IBAN the API returns.
The confirm button is not locked; an EUR quote can still be tapped to confirm.
DE:
Diese Tests stellen sicher, dass ein EUR-Kauf die Währung EUR sendet und die EUR-IBAN aus der Quote zeigt, nicht eine übrig gebliebene CHF-IBAN.
Der Produktionscode bleibt unverändert: er leitet die gewählte Währung bereits weiter und zeigt die IBAN der API.
Der Bestätigen-Button wird nicht gesperrt; eine EUR-Quote lässt sich weiterhin bestätigen.
Details
Pins the EUR vs CHF buy-quote IBAN contract in existing test files:
PUT /v1/realunit/buywithCurrency.euriscurrency: EURand maps the EUR IBAN from the mock response.RealUnitBuyPaymentInfoDto.fromJsonparses EUR IBAN + EUR currency.BuyPaymentInfoCubitsuccess for EUR keeps the EUR IBAN.BuyViewrefetches the quote withCurrency.eur.BuyPaymentInfoSuccess,BuyConfirmButtonreceives the EUR IBAN (not the CHF leftover).confirmPayment.IBANs used as distinct fixtures:
CH2208307000560946309→CH22 0830 7000 5609 4630 9CH9708307000560946317→CH97 0830 7000 5609 4631 7No production
lib/changes.