Skip to content

01a03ced - Wait for incoming slides before starting process work - #946

Merged
TaprootFreak merged 1 commit into
RealUnitCH:stagingfrom
TaprootFreakAI:fix/01a03ced-route-animation-gate
Aug 26, 2026
Merged

01a03ced - Wait for incoming slides before starting process work#946
TaprootFreak merged 1 commit into
RealUnitCH:stagingfrom
TaprootFreakAI:fix/01a03ced-route-animation-gate

Conversation

@TaprootFreakAI

Copy link
Copy Markdown
Collaborator

EN:
Pay, quote load, and sell-bitbox now wait for the incoming route slide to finish before starting work or opening a result sheet. The send-process gate is extracted into a shared widget so the same handling is not duplicated. Fast failures no longer overlay the previous screen mid-slide.

DE:
Pay, Quote-Laden und Sell-BitBox warten, bis der eingehende Slide fertig ist, bevor Arbeit startet oder ein Ergebnisdialog aufgeht. Der Send-Prozess-Gate liegt in einem gemeinsamen Widget, damit dasselbe Handling nicht dupliziert wird. Schnelle Fehler übermalen nicht mehr die vorige Seite mitten im Slide.

Details

RouteAnimationGate ignores the first-frame kAlwaysCompleteAnimation placeholder. onSettled runs from the context below BlocProvider. Result/reconnect sheets still call waitForIncomingRouteAnimation as a second wait.

Widget tests cover the shared gate and the pay-process 300 ms slide. SellBitbox cubit tests call start() explicitly; the constructor no longer auto-starts.

Extract RouteAnimationGate from the send-process page and use it for
pay, quote load, and sell-bitbox so a fast failure cannot overlay the
still-sliding previous screen.
@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review August 26, 2026 12:25
@TaprootFreakAI

Copy link
Copy Markdown
Collaborator Author

EN:
Ready after 1 review pass.
Pay, quote, and sell-bitbox now wait for the incoming route slide to finish before starting work or opening a result sheet, using one shared gate instead of copied send-process handling.

DE:
Bereit nach 1 Review-Durchlauf.
Pay, Quote und Sell-BitBox warten, bis der eingehende Slide fertig ist, bevor Arbeit startet oder ein Ergebnisdialog aufgeht, mit einem gemeinsamen Gate statt kopiertem Send-Handling.

Details

Review: 1 pass, 0 findings. No open issue comments, reviews, inline comments, or review threads.

Mergeability at 33db2471: mergeable=MERGEABLE (mergeStateStatus BLOCKED is the approval/ruleset gate, not a conflict). Base staging. Commit verified.

Required checks on this head:

  • Analyze & Test — success
  • Visual Regression — success
  • Coverage Floor Gate — success

Also green, not required: BitBox quirks audit, Handbook Build Check.

Maestro handbook flows stayed skipped: tier3-handbook.yaml only runs with the tier3:full label. Not a required check.

@TaprootFreak
TaprootFreak merged commit d0174ce into RealUnitCH:staging Aug 26, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants