01a042cc - Golden for the collapsed all-zero portfolio chart - #953
Merged
TaprootFreak merged 9 commits intoAug 27, 2026
Merged
Conversation
When every holding in the window is 0, LineChart currently draws no curve. The snapshot records that empty chart. A temporary CI step uploads runner-rendered goldens so the missing PNG can be committed.
TaprootFreakAI
marked this pull request as ready for review
August 27, 2026 17:06
TaprootFreakAI
marked this pull request as draft
August 27, 2026 17:08
Rendered on the self-hosted visual-regression runner. Reverts the temporary artifact-upload workflow change used to capture the PNG.
TaprootFreakAI
marked this pull request as ready for review
August 27, 2026 17:09
Each period is tapped so the empty plot is snapshotted with that tab selected. Temporary CI step uploads runner-rendered PNGs.
TaprootFreakAI
marked this pull request as draft
August 27, 2026 17:46
TaprootFreakAI
marked this pull request as ready for review
August 27, 2026 17:46
TaprootFreakAI
marked this pull request as draft
August 27, 2026 17:48
The helper returned the wrong Future shape, so the 1W/1M/3M/1J snapshots never compiled on the visual-regression runner.
TaprootFreakAI
marked this pull request as ready for review
August 27, 2026 17:50
TaprootFreakAI
marked this pull request as draft
August 27, 2026 17:52
Rendered on the self-hosted visual-regression runner. Reverts the temporary artifact-upload workflow change used to capture the PNGs.
TaprootFreakAI
marked this pull request as ready for review
August 27, 2026 17:52
TaprootFreakAI
marked this pull request as draft
August 27, 2026 17:53
TaprootFreakAI
marked this pull request as ready for review
August 27, 2026 17:53
Holdings older than one year draw on MAX; zeros in the recent windows collapse LineChart so 1W/1M/3M/1J match the reported empty plot.
TaprootFreakAI
marked this pull request as draft
August 27, 2026 18:07
TaprootFreakAI
marked this pull request as ready for review
August 27, 2026 18:07
TaprootFreakAI
marked this pull request as draft
August 27, 2026 18:09
Baselines from the self-hosted visual-regression runner. Reverts the temporary artifact-upload workflow change used to capture the PNGs.
TaprootFreakAI
marked this pull request as ready for review
August 27, 2026 18:10
TaprootFreakAI
marked this pull request as draft
August 27, 2026 18:10
TaprootFreakAI
marked this pull request as ready for review
August 27, 2026 18:10
A 4px splash on 1W failed Visual Regression. Pump 400ms after tap and re-render baselines on the runner.
TaprootFreakAI
marked this pull request as draft
August 27, 2026 18:12
TaprootFreakAI
marked this pull request as ready for review
August 27, 2026 18:12
TaprootFreakAI
marked this pull request as draft
August 27, 2026 18:15
MAX keeps the curve; 1W–1J stay empty. Reverts the temporary artifact-upload workflow change used to capture the PNGs.
TaprootFreakAI
marked this pull request as ready for review
August 27, 2026 18:15
TaprootFreak
pushed a commit
that referenced
this pull request
Aug 27, 2026
EN: The portfolio development chart disappeared for time windows where every holding is zero. The cubit now keeps a Y-range from 0 so the line stays drawn, and holds the last value before the window so the stroke spans the selected period. A dashboard golden records the all-zero MAX view; the customer-report 1W–1J goldens show that full-width zero line on a 0…10 axis. Unit tests cover an all-zero series, a one-week window of zeros, and carrying a pre-window sample to minX. DE: Die Bestandsentwicklung verschwand in Zeitfenstern, in denen jeder Punkt 0 ist. Der Cubit hält jetzt eine Y-Spanne ab 0, damit die Linie gezeichnet bleibt, und übernimmt den letzten Wert vor dem Fenster, damit der Strich die gewählte Periode ausfüllt. Ein Dashboard-Golden dokumentiert die Null-MAX-Ansicht; die Kunden-Goldens 1W–1J zeigen diese volle Null-Linie auf einer Achse 0…10. Unit-Tests decken eine Null-Serie, ein 1W-Null-Fenster und das Nachziehen eines Werts vor minX ab. <details> <summary>Details</summary> When every visible point is 0, `average * 0.05` was 0, so `minY == maxY == 0` and `LineChart` drew no curve. The cubit now falls back to a 5.0 currency-unit floor so the chart has a Y-range. Holdings cannot go negative: the bottom line is always clamped to 0 (scale 0…10 for an all-zero series), not centered through negative labels. A clipped period (1W/1M/3M/1J) previously started the stroke at the first interior sample. If that sample sat months into the window, the line began mid-chart. The last sample before `minX` is now held at the window edge so the stroke spans the selected period. An empty window (every sample older than the period) stays empty. `dashboard_portfolio_chart_zero.png` is the all-zero MAX view. After #953, the mixed-history 1W/1M/3M/1J goldens pin the full-width zero line on the 0-axis. </details> --------- Co-authored-by: TaprootFreakAI <315477232+TaprootFreakAI@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
This PR reproduces the customer chart bug as goldens, without a product fix.
MAX shows the old holdings curve, then a drop to zero. 1W, 1M, 3M and 1J show the empty plot.
DE:
Dieser PR bildet den Kunden-Chart-Bug als Goldens ab, ohne Produkt-Fix.
MAX zeigt die alte Bestandskurve, dann den Abfall auf 0. 1W, 1M, 3M und 1J zeigen die leere Fläche.
Details
Fixtures: non-zero points older than one year (MAX curve), then zeros through now (1W–1J collapse with
minY == maxY == 0). Same sequence the customer reported. PNGs from the self-hosted visual-regression runner.