Release: develop -> main#19
Merged
Merged
Conversation
Lower-case the email before building the confirm-aktionariat GET URL so a mixed-case address (mail clients, manual copy) no longer triggers a spurious 400 that surfaced to the user as a misleading "temporarily unavailable" loop; code and user stay opaque and case-sensitive. Add fire-and-forget durable logging of each confirm lifecycle stage (pageLoaded / missingParams / requestSent / resultConfirmed|Invalid|Unavailable / requestError) to POST /v1/realunit/confirm-aktionariat/event on the same DFX API host, already covered by the page CSP connect-src so no _headers change is needed. Logging never blocks or alters the UX and is skipped for the local ?mock preview so no fabricated outcomes reach the diagnostic log. Pure URL/body helpers (buildConfirmUrl lower-casing, buildEventUrl, buildEventBody) are unit-tested to 100%; the fetch glue and phase wiring are covered by the Playwright behavior suite.
TaprootFreak
approved these changes
Jul 12, 2026
…tion (#20) Remove the fire-and-forget lifecycle-event beacon added in #18: the logEvent helper, the RESULT_PHASE map and every logEvent call in confirm.js, plus buildEventUrl/buildEventBody in confirm-core.js with their unit tests and the Playwright event-phase assertions (the confirm-vs-event route-matcher split is simplified back to the confirm GET). The paired public DFX-API event endpoint is being removed API-side: it only captured low-value client-only events at the cost of a public, unauthenticated PII-write endpoint, while the real confirm audit is done API-internally. The web therefore stops calling it. The confirm flow, the four UX states, the return-to-app button and the email lower-casing in buildConfirmUrl (with its unit and behaviour tests) are unchanged.
TaprootFreak
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist