Apply Rebel coding style#19
Merged
Merged
Conversation
- Move class_db.h dependency in object.h to the top of the header. - Remove object.h dependency in class_db.h. - Remove object.h dependency in method_bind.h. - Move PropertyInfo and MethodInfo declarations to type_info.h. - Move Object variant enum cast to object.cpp - Add missing dependencies: - Add hash_map.h dependency to class_db.h - Add color.h dependency to color_names.inc
Contributor
|
Thank you! |
This was referenced Jun 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A good coding style makes the code easier to read and troubleshoot. This PR defines and applies the Rebel coding style.
clang-formatis used to standardise the coding style used. Although it does an amazing job, it is not bug-free, and sometimesclang-formatdoes not apply the coding style as expected. Many of these issues can be resolved by modifying (simplifying!) the code, but not always./* clang-format off */can be used to disableclang-formatin a particular section of code, but it should be used sparingly. It should not be used to "fix" a bug inclang-format, because, when the bug is fixed, it will continue to disableclang-format. If the unexpected application of the coding style cannot be fixed by modifying the code, but it is tolerable, it is better not to use/* clang-format off */.This PR splits the application of the Rebel coding style into multiple commits. This makes it easier to see the changes that
clang-formathas made. This is especially relevant when the application of aclang-formatrule has made some noticeably unexpected changes.The application of the Rebel coding style revealed some hidden bugs. These have also been addressed.