Update clang-format's pre-commit hook's minimum version to 16#75
Merged
Conversation
DanielaOrtner
approved these changes
Jun 9, 2024
Contributor
DanielaOrtner
left a comment
DanielaOrtner
left a comment
There was a problem hiding this comment.
Great work! Keep it coming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #19, we used
clang-formatto apply Rebel's coding style. Our git hooks help contributors to automatically apply Rebel's coding style. Currently, thepre-commit-clang-formathook checks the version ofclang-formatinstalled and warns if it is not between versions 14 and 17. However, Rebel's coding style usesclang-formatfunctionality added in version 16, which was released in March 2023. So, if the contributor is using an earlier version ofclang-format,clang-formatwill fail.This PR updates the minimum version required to 16. It will also cause the pre-commit hook to fail, which prevents earlier versions of
clang-formatfailing and deleting files. It also warns if the version doesn't match the version used by CI checks: currently 17, which was released in September 2023 and includes fixes present in version 16.