Skip to content

ci: restore supported standard GitHub-hosted runners - #17

Merged
RecursiveIntell merged 1 commit into
mainfrom
fix/restore-standard-github-runners-20260831
Aug 31, 2026
Merged

ci: restore supported standard GitHub-hosted runners#17
RecursiveIntell merged 1 commit into
mainfrom
fix/restore-standard-github-runners-20260831

Conversation

@RecursiveIntell

Copy link
Copy Markdown
Owner

Summary

Restore Ares CI to its previously admitted standard GitHub-hosted runner topology.

The repository is owned by the personal GitHub account RecursiveIntell, not an organization. The configured larger-runner labels do not admit under that ownership, leaving affected CI/Nix jobs queued without a runner assignment.

This change:

  • restores 12 split Python test slices with deterministic LPT discovery;
  • restores the dynamic standard-runner JS/TS check matrix;
  • preserves desktop UI shards and plugin checks;
  • keeps macOS and Windows tests on native hosted runners;
  • restores standard Linux runners for Nix, Rust, desktop E2E, and amd64 Docker;
  • uses ubuntu-24.04-arm for the arm64 Docker lane;
  • removes the custom larger-runner actionlint declaration and merged-workspace helper;
  • does not modify permit, receipt, runtime, service, enrollment, or canary paths.

Trigger evidence

  • 12 Ares CI/Nix runs were queued across main and unrelated PRs.
  • Queued larger-runner jobs reported runner_id: 0 with no runner name.
  • Standard ubuntu-latest and macos-latest jobs in the same runs completed.
  • GitHub reports repository owner type User; larger hosted runners require qualifying organization or enterprise ownership.

Local validation

  • all 30 workflow YAML files parse;
  • actionlint v1.7.12 reports zero candidate findings (base reports two invalid sparse-checkout inputs removed here);
  • no unavailable larger-runner labels remain;
  • Python slice generation produced 12 nonempty slices covering 3,367 unique files with no duplicates;
  • focused run_tests.sh --files execution passed 8 tests across 2 files;
  • static JS discovery retained 7 workspaces and 13 checks, including plugin tests and UI shards 1/3–3/3;
  • UI shard identity validation accepts the valid family and rejects an inconsistent 4/4 family;
  • git diff --check passes.

Two earlier local test-command attempts stopped before execution because the isolated worktree/runtime venv lacked pytest; the successful rerun used the existing Ares development venv. Hosted CI remains the decisive execution gate.

Publication boundary

Public Evidence Editor outcome for commit/push/open PR: APPROVE_WITH_QUALIFIERS.

Receipt: /home/sikmindz/.ares/profile-collaboration/receipts/20260831T055439Z-fad4b9e0

Merge is intentionally deferred until standard hosted runners admit the jobs, affected checks reach acceptable terminal states, matrix cardinality is confirmed, and a renewed public closeout review passes.

Non-claims

This PR does not claim that CI is already fixed, all tests passed, performance is equivalent, the baseline Windows-footgun debt is resolved, or the paired permit contract is validated, merged, or live.

The personal-account-owned repository cannot admit the organization-only 32/96-core larger-runner labels introduced by 10f99bc. Reverse that topology and its 0012dd1 worker tuning, restoring the prior split Python and JS coverage, native OS lanes, standard Nix/Rust/E2E/Docker runners, and arm64 hosted runner without changing permit or canary source.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T06:06:58.891809Z 5d5d4ba PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

૮ >ﻌ< ა ci review

ran on 5d5d4ba — ci: restore supported standard GitHub-hosted runners

❌ Job failures

Docs Site / docs-site-checks · View job

Job Docs Site / docs-site-checks failed.


JS & TS checks / apps/desktop / check:test:ui:shard-2of3 · View job

Job JS & TS checks / apps/desktop / check:test:ui:shard-2of3 failed.


JS & TS checks / tests-js / check · View job

Job JS & TS checks / tests-js / check failed.


OS-specific tests / Windows-only tests · View job

Job OS-specific tests / Windows-only tests failed.


Python lints / Windows footguns (blocking) · View job

Job Python lints / Windows footguns (blocking) failed.


Python tests / Run tests slice 2/12 · View job

Job Python tests / Run tests slice 2/12 failed.


Python tests / Run tests slice 5/12 · View job

Job Python tests / Run tests slice 5/12 failed.


Python tests / Run tests slice 8/12 · View job

Job Python tests / Run tests slice 8/12 failed.


Python tests / Run tests slice 9/12 · View job

Job Python tests / Run tests slice 9/12 failed.


⚠️ Warnings

OSV vulnerability scan · View job

10 known vulnerabilities found in pinned dependencies.

How to fix:

Review the findings in the Security tab. Update the affected dependencies if a patched version is available.


ℹ️ Info

CI-sensitive file review · View job

PR touches sensitive files, but the ci-reviewed label has been added, approving them.

Sensitive files changed:


debug info

CI timings

CI timings · View report · View job

Wall time 18m28s vs 1440m18s (-98.7%). 7 job(s) slower, 8 faster, 2 unchanged.

  • Rust tests / cargo test (bootstrap installer): -86226.0s
  • OS-specific tests / Windows-only tests: -86223.0s
  • Lint Docker scripts / Lint Dockerfile (hadolint): -14.0s
  • OS-specific tests / macOS-only tests: +8.0s
  • Installer tests / PowerShell installer tests: -8.0s

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d5d4bae32

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/desktop/package.json
"check:test:desktop:all": "npm run test:desktop:all",
"check:lint": "npm run typecheck && npm run lint",
"check": "npm run check:lint && npm run test:ui && npm run test:desktop:platforms && npm run test:desktop:all && npm run check:test:plugins",
"check": "npm run check:lint && npm run test:ui && npm run test:desktop:platforms && npm run test:desktop:all",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep plugin tests in the desktop aggregate check

When a contributor or automation runs the aggregate npm run check --workspace=apps/desktop, the plugin suite no longer executes even though check:test:plugins remains defined. The new CI matrix invokes that sub-check separately, but other consumers of the package's canonical aggregate command now report success without running src/plugins/*/tests/*.test.mjs; retain npm run check:test:plugins in this command.

Useful? React with 👍 / 👎.

@RecursiveIntell RecursiveIntell added the ci-reviewed CI-sensitive changes independently reviewed label Aug 31, 2026
@RecursiveIntell
RecursiveIntell merged commit f3456be into main Aug 31, 2026
137 of 170 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-reviewed CI-sensitive changes independently reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant