fix: raise ValueError in _all_tasks_done when given empty list#223
Merged
fix: raise ValueError in _all_tasks_done when given empty list#223
Conversation
Prevents vacuous truth: calling _all_tasks_done([]) previously returned (True, []) which would silently permit releasing a version with zero tasks if the caller-side guard were ever removed. Now raises ValueError explicitly, and the test contract is updated to expect the error instead of True.
3 tasks
fazxes
added a commit
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_all_tasks_done([])previously returned(True, [])-- vacuous truth that would silently permit releasing a version with zero tasks if the upstreamif not task_files:guard were ever removedValueError("_all_tasks_done requires at least one task file")on empty inputtest_empty_file_list_returns_truerenamed totest_empty_file_list_raises_value_errorand updated to assert the errorTest plan
make checkpasses (997 tests, ruff, mypy, dry-runs, ASCII, shell syntax all green)_all_tasks_done([])raisesValueErrorwith a descriptive message_all_tasks_donecall sites remain correct --_version_readystill guards withif not task_files:before calling, so no callers ever pass an empty list