Conversation
Fix inline comment in module_map.py that incorrectly said "second column is CIRCUIT-BREAK" when cols[2] is the third split element (session-id). Fix test helper _make_session_index to use zero-padded date formatting (i+1:02d) to prevent malformed timestamps like "2026-04-010" for rows beyond 9.
fazxes
added a commit
that referenced
this pull request
Apr 9, 2026
…y report Tasks created from analysis of sessions #107-#122 and 7 human-filed issues: - #241 (urgent): fix worktree cleanup -- .claude/worktrees/agent-* leaking - #242 (urgent): add sessions_since_eval signal + brain eval cadence rule - #243 (normal): run nightshift against Phractal immediately (eval #17) Root causes identified: eval loop broken (14 sessions stale), worktree leak confirmed live, Phractal E2E never runs in daemon cadence.
3 tasks
fazxes
added a commit
that referenced
this pull request
Apr 9, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nightshift/infra/module_map.py(line ~364): previous comment said "second column is CIRCUIT-BREAK" butcols[2]is the third split element (cols[0]=empty, cols[1]=timestamp, cols[2]=session-id). Reworded to accurately describe the split indexing._make_session_indexhelper innightshift/tests/test_module_map.py: timestamps were generated withf"2026-04-0{i+1}"which produces malformed strings like"2026-04-010"for row index >= 9. Changed tof"2026-04-{i+1:02d}"for correct zero-padding.Closes task #240 (source: pr-239-review).
Test plan
make checkpasses (1142 tests, ruff, mypy, dry-runs, ASCII check all green)