feat: production-readiness checker module for Loop 2#69
Merged
Conversation
Add nightshift/readiness.py with configurable post-build checks: - Secret/credential detection (API keys, AWS keys, GitHub PATs, passwords) - Debug statement scanning (print, console.log, debugger, breakpoint, pdb) - Test coverage verification (production files have corresponding test files) Integrated into build_feature() pipeline after final verification. Returns structured ReadinessReport with per-check pass/fail and verdict. Configurable via readiness_checks list in .nightshift.json. 40 new tests. Loop 2: 72% -> 81%. Overall: 82% -> 85%. Closes task #68.
Safety reviewer caught that a malicious target repo could place symlinks at paths reported in files_created/files_modified, causing the scanner to follow them outside the repo. Add is_symlink() guards at all 3 file-access points in check_secrets(), check_debug_prints(), and check_test_coverage().
fazxes
added a commit
that referenced
this pull request
Apr 6, 2026
fazxes
added a commit
that referenced
this pull request
Apr 7, 2026
Closed 20 tasks with evidence: - DONE (2): #73 (AGENTS.md created), #181 (docs/prompt/ deleted) - WONTFIX-OBSOLETE (5): #78, #89, #128, #141, #157 (reference docs/prompt/ or docs/ops/ paths deleted in session #103) - WONTFIX-DUPLICATE (1): #88 (subset of #69) - WONTFIX-NEVER-PICKED (12): #66, #69, #90, #96, #112, #114, #120, #123, #132, #133, #138, #145 (low priority, 20-80+ sessions without being picked, speculative) Priority fix: #103 downgraded from urgent to normal (umbrella epic, not an actionable urgent fix).
fazxes
added a commit
that referenced
this pull request
Apr 7, 2026
…st tasks Queue cleanup after session #103 major restructuring: Closed (8): - #73: AGENTS.md exists (commit 38e1fe5) - #88: duplicate of #69 (auto-changelog) - #141: obsolete (docs/prompt/evolve.md deleted) - #157: obsolete (docs/prompt/feedback/ deleted) - #159: consolidated into #190 - #161: consolidated into #190 - #181: obsolete (docs/prompt/unified.md deleted) - #184: done (fixed by PR #179) Path updates (30+ tasks): - docs/ -> .recursive/ or Recursive/ops/ - scripts/daemon.sh -> Recursive/engine/daemon.sh - scripts/lib-agent.sh -> Recursive/engine/lib-agent.sh - .nightshift.json -> .recursive.json - nightshift/*.py -> nightshift/{core,owl,raven,infra}/*.py Pentest tasks created (4): - #194: budget limiter triple-failure (CONFIRMED) - #195: python3 -c path interpolation (CONFIRMED) - #196: .recursive.json prompt guard (THEORETICAL) - #197: costs.json negative value validation (THEORETICAL)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nightshift/readiness.pymodule with configurable post-build production-readiness checks: secret detection, debug statement scanning, test coverage verificationbuild_feature()pipeline after final verificationReadinessCheckandReadinessReportTypedDicts;readinessfield onFeatureState;readiness_checksconfig keyTest plan
make checkpasses (ruff, mypy strict, pytest 725/725, dry-run both agents, shell syntax, ASCII, install refs)readinessfield load withreadiness=None