Stop using the instructional flag. - #7
Merged
Hyperkid123 merged 1 commit intoNov 21, 2022
Conversation
platex-rehor-bot
added a commit
to platex-rehor-bot/learning-resources
that referenced
this pull request
Apr 16, 2026
RHCLOUD-46729 Reword convention RedHatInsights#7 to make clear that useChrome is the sole public interface — don't import other Chrome internals. Addresses coderabbit review nitpick.
4 tasks
karelhala
pushed a commit
that referenced
this pull request
Apr 16, 2026
* docs: add agent readiness files RHCLOUD-46729 Add AGENTS.md with project structure, conventions, module federation table, tech stack, pitfalls, and doc index. Add docs/*-guidelines.md for testing, security, error handling, and integration. Prepend @AGENTS.md import and build commands to existing CLAUDE.md. * docs: add application parts section RHCLOUD-46729 Address reviewer feedback: add Application Parts section to AGENTS.md describing the 3 user-facing surfaces (all learning resources page, bundle-specific pages, help panel) plus the creator tool. Add missing npm run verify command to claude.md. * docs: document API call exceptions RHCLOUD-46729 Update convention #9 to acknowledge 5 legacy components with inline API calls. Mark as tech debt to migrate when touching those files. * docs: clarify Chrome API abstraction RHCLOUD-46729 Reword convention #7 to make clear that useChrome is the sole public interface — don't import other Chrome internals. Addresses coderabbit review nitpick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.